New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #39. Send custom HTTP header when reporting issue. #40

Merged
merged 3 commits into from Sep 9, 2016

Conversation

Projects
None yet
2 participants
@miketaylr
Member

miketaylr commented Sep 8, 2016

Not added to Chrome or Opera yet, will do in a follow up commit before merging once it gets an r+.

@karlcow, r?

return {requestHeaders: details.requestHeaders};
},
{urls: ["https://webcompat.com/?open=1&*"]},

This comment has been minimized.

@miketaylr

miketaylr Sep 8, 2016

Member

If I left this as just https://webcompat.com/, it didn't work (which was surprising), and https://webcompat.com/* modifies headers for static assets requests, which we don't need.

@miketaylr

miketaylr Sep 8, 2016

Member

If I left this as just https://webcompat.com/, it didn't work (which was surprising), and https://webcompat.com/* modifies headers for static assets requests, which we don't need.

This comment has been minimized.

@karlcow

karlcow Sep 9, 2016

Contributor

yes explained in https://developer.chrome.com/extensions/match_patterns
btw, I have the feeling there is a typo in MDN s/url/urls/, but you have it right yourself.
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/WebRequest/onBeforeSendHeaders#details

@karlcow

karlcow Sep 9, 2016

Contributor

yes explained in https://developer.chrome.com/extensions/match_patterns
btw, I have the feeling there is a typo in MDN s/url/urls/, but you have it right yourself.
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/WebRequest/onBeforeSendHeaders#details

@miketaylr

This comment has been minimized.

Show comment
Hide comment
Member

miketaylr commented Sep 8, 2016

screen shot 2016-09-08 at 5 54 58 pm

@karlcow

This comment has been minimized.

Show comment
Hide comment
@karlcow

karlcow Sep 9, 2016

Contributor

r+ Thanks mike 😍

Contributor

karlcow commented Sep 9, 2016

r+ Thanks mike 😍

@karlcow karlcow merged commit 5418b4b into master Sep 9, 2016

@miketaylr

This comment has been minimized.

Show comment
Hide comment
@miketaylr

miketaylr Sep 9, 2016

Member

Thanks Karl!

Member

miketaylr commented Sep 9, 2016

Thanks Karl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment