New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2668 - Add a flag to specify address to listen on #2669

Merged
merged 1 commit into from Oct 25, 2018

Conversation

Projects
None yet
3 participants
@marimeireles
Copy link
Contributor

marimeireles commented Oct 23, 2018

@karlcow

Now you can do python run.py -l 0.0.0.0 for example and connect with other devices on your local dev env :)

If you don't pass any parameter to it the default is localhost as it was before.

@miketaylr miketaylr requested a review from karlcow Oct 23, 2018

@miketaylr

This comment has been minimized.

Copy link
Member

miketaylr commented Oct 23, 2018

(oh cool, nice addition!)

@marimeireles

This comment has been minimized.

Copy link
Contributor Author

marimeireles commented Oct 23, 2018

Hi @miketaylr , thanks! :)
I'm sorry not to ping you, but I thought I read somewhere I should ping Karl when I it's about python. Also, you seemed super busy today from what I saw on IRC, didn't want to bother. But you can review my PRs whenever you want haha

@miketaylr

This comment has been minimized.

Copy link
Member

miketaylr commented Oct 23, 2018

Heh, no worries. I ping @karlcow for python reviews too. :)

@marimeireles marimeireles changed the title Fixes #2668 - Add a flag to specify adress to listen on Fixes #2668 - Add a flag to specify address to listen on Oct 25, 2018

@karlcow
Copy link
Contributor

karlcow left a comment

@marimeireles very cool!

@karlcow karlcow merged commit 00a8554 into webcompat:master Oct 25, 2018

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment