Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WCJS] out of stack issue in ie #43

Open
Khushboo-chaurasiya opened this issue May 10, 2019 · 14 comments
Open

[WCJS] out of stack issue in ie #43

Khushboo-chaurasiya opened this issue May 10, 2019 · 14 comments

Comments

@Khushboo-chaurasiya
Copy link

@Khushboo-chaurasiya Khushboo-chaurasiya commented May 10, 2019

I am getting out of stack issue in ie but I want to resolve it without using core.min.js

@abergd
Copy link

@abergd abergd commented May 15, 2019

Same here!

@emilio-martinez
Copy link
Contributor

@emilio-martinez emilio-martinez commented May 22, 2019

I'm also getting this error, amongst others on IE11.

Screen Shot 2019-05-22 at 11 04 58 AM

@dfreedm dfreedm transferred this issue from webcomponents/webcomponentsjs Jun 7, 2019
@MonsieurMan
Copy link

@MonsieurMan MonsieurMan commented Jun 11, 2019

I am having the exact same issue.

Stack overflow at line: 78
webcomponents-sd-ce-pf.js (78,288)

@web-padawan
Copy link
Contributor

@web-padawan web-padawan commented Jun 11, 2019

IIRC this happens because of Symbol polyfill (especially when also using the polyfill from core-js).

@MonsieurMan
Copy link

@MonsieurMan MonsieurMan commented Jun 12, 2019

@web-padawan That is exactly my case.
I'm trying to make web components work under Angular and I'm using these polyfills.

I'll update this thread with anything I find.

@dfreedm dfreedm changed the title out of stack issue in ie [WCJS] out of stack issue in ie Jun 12, 2019
@kasjerJanusz
Copy link

@kasjerJanusz kasjerJanusz commented Jun 18, 2019

Same here when using these both polyfills:

import '../../../../../node_modules/@webcomponents/webcomponentsjs/webcomponents-bundle.js';
import '../../../../../node_modules/@babel/polyfill/dist/polyfill.js';

When using only one of them, the error doesn't appears.

@web-padawan
Copy link
Contributor

@web-padawan web-padawan commented Jun 18, 2019

So let me summarise the problem in its current shape:

  1. All the "mainstream" ecosystem is using core-js polyfills (which Babel depends on).

  2. Philosophy of webcomponentsjs has been always to bring its own polyfills for builtins like Object.assign, Array.from and Symbol to allow using without Babel.

  3. Now, two approaches collide because of polyfills are not well tested against one another.

I would highly recommend to reconsider shipping a "bare" polyfill bundle (even though there is already a loader by @open-wc which kinda addresses the same issue).

@sorvell @azakus WDYT ?

@ba55ie
Copy link

@ba55ie ba55ie commented Jul 3, 2019

I also ran into this problem. My temporary fix: Clone this repo and create a custom build which excludes the Symbol polyfill.

@phetw
Copy link

@phetw phetw commented Sep 24, 2019

@webcomponents/webcomponentsjs@2.1.2 is the latest version that I was able to run Angular 8 on IE11 without this exception.

@Rahulgarg30591
Copy link

@Rahulgarg30591 Rahulgarg30591 commented Nov 25, 2019

@MonsieurMan are you able to find anything?

@MonsieurMan
Copy link

@MonsieurMan MonsieurMan commented Nov 25, 2019

@Rahulgarg30591, well we finally got a positive response on stopping IE support as we develop internal wep apps only.

@web-padawan and @ba55ie comment are the only thing we can do. It's sad it has not been done as part of this repository.

@nadavsinai
Copy link

@nadavsinai nadavsinai commented Jan 1, 2020

for me version 2.1.2 didn't work with Angular 8 but 2.2.7 did work.
anything later doesn't work

@bschlenk
Copy link

@bschlenk bschlenk commented Feb 19, 2020

I was able to come up with a super minimal repro for this issue. Details are explained in this repo: https://github.com/bschlenk/ie11-corejs-stack-overflow-repro

Happens when get-own-property-symbols is included before core-js web.dom-collections.iterator (and potentially other core-js polyfills).

auzmartist added a commit to auzmartist/polyfills that referenced this issue May 21, 2020
The Symbol polyfill causes a stack overflow exception on IE11 when used in conjunction with core-js, a babel standard package which is widely used.

This is further documented [here](webcomponents#43)
@stale
Copy link

@stale stale bot commented Apr 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet