Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WCJS] out of stack issue in ie #43

Open
Khushboo-chaurasiya opened this issue May 10, 2019 · 9 comments

Comments

@Khushboo-chaurasiya
Copy link

@Khushboo-chaurasiya Khushboo-chaurasiya commented May 10, 2019

I am getting out of stack issue in ie but I want to resolve it without using core.min.js

@abergd

This comment has been minimized.

Copy link

@abergd abergd commented May 15, 2019

Same here!

@emilio-martinez

This comment has been minimized.

Copy link
Contributor

@emilio-martinez emilio-martinez commented May 22, 2019

I'm also getting this error, amongst others on IE11.

Screen Shot 2019-05-22 at 11 04 58 AM

@azakus azakus transferred this issue from webcomponents/webcomponentsjs Jun 7, 2019
@MonsieurMan

This comment has been minimized.

Copy link

@MonsieurMan MonsieurMan commented Jun 11, 2019

I am having the exact same issue.

Stack overflow at line: 78
webcomponents-sd-ce-pf.js (78,288)
@web-padawan

This comment has been minimized.

Copy link
Contributor

@web-padawan web-padawan commented Jun 11, 2019

IIRC this happens because of Symbol polyfill (especially when also using the polyfill from core-js).

@MonsieurMan

This comment has been minimized.

Copy link

@MonsieurMan MonsieurMan commented Jun 12, 2019

@web-padawan That is exactly my case.
I'm trying to make web components work under Angular and I'm using these polyfills.

I'll update this thread with anything I find.

@azakus azakus changed the title out of stack issue in ie [WCJS] out of stack issue in ie Jun 12, 2019
@kasjerJanusz

This comment has been minimized.

Copy link

@kasjerJanusz kasjerJanusz commented Jun 18, 2019

Same here when using these both polyfills:

import '../../../../../node_modules/@webcomponents/webcomponentsjs/webcomponents-bundle.js';
import '../../../../../node_modules/@babel/polyfill/dist/polyfill.js';

When using only one of them, the error doesn't appears.

@web-padawan

This comment has been minimized.

Copy link
Contributor

@web-padawan web-padawan commented Jun 18, 2019

So let me summarise the problem in its current shape:

  1. All the "mainstream" ecosystem is using core-js polyfills (which Babel depends on).

  2. Philosophy of webcomponentsjs has been always to bring its own polyfills for builtins like Object.assign, Array.from and Symbol to allow using without Babel.

  3. Now, two approaches collide because of polyfills are not well tested against one another.

I would highly recommend to reconsider shipping a "bare" polyfill bundle (even though there is already a loader by @open-wc which kinda addresses the same issue).

@sorvell @azakus WDYT ?

@ba55ie

This comment has been minimized.

Copy link

@ba55ie ba55ie commented Jul 3, 2019

I also ran into this problem. My temporary fix: Clone this repo and create a custom build which excludes the Symbol polyfill.

@phetw

This comment has been minimized.

Copy link

@phetw phetw commented Sep 24, 2019

@webcomponents/webcomponentsjs@2.1.2 is the latest version that I was able to run Angular 8 on IE11 without this exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.