New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't swallow window events #175

Merged
merged 1 commit into from Nov 22, 2017

Conversation

Projects
None yet
2 participants
@dalvarezmartinez1

dalvarezmartinez1 commented Aug 30, 2017

The current implementation seems to swallow, ignore the 'load' event at least when fired from window. An issue has been created here.
Below is my attempt to solve it


Added by @azakus
Fixes webcomponents/webcomponentsjs#836

@sorvell sorvell requested a review from azakus Nov 22, 2017

@azakus

azakus approved these changes Nov 22, 2017

Looks good to me, we can add a test and merge.

@azakus azakus merged commit 10d7267 into webcomponents:master Nov 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment