Skip to content
This repository has been archived by the owner. It is now read-only.

[ Add ] Utility methods of ParentNode & ChildNode interfaces #294

Closed
wants to merge 5 commits into from

Conversation

@TechQuery
Copy link

@TechQuery TechQuery commented Nov 16, 2018

Reference Issue

Fixes #288

@TechQuery TechQuery requested review from dfreedm and sorvell as code owners Nov 16, 2018
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Please add braces to all if-statements. Also, please add regression tests for these methods.

@TechQuery
Copy link
Author

@TechQuery TechQuery commented Nov 19, 2018

@TimvdLippe
I found a bug of Building scripts: only the name of prepend() is transformed, I don't know why...
image

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

I think all methods need the following JSdoc notation:

/**
  * @this {HTMLElement}
  */

This is also going to clash with #298, but I think it is better to wait for that PR to land before going ahead with this one.

<script>
ShadyDOM = {force: true};
</script>
<!-- <script src="../shadydom.min.js"></script> -->

This comment has been minimized.

@TimvdLippe

TimvdLippe Nov 19, 2018
Contributor

Uncomment this file.

This comment has been minimized.

@TechQuery

TechQuery Nov 19, 2018
Author

If you uncomment this line, you'll meet this bug.

This comment has been minimized.

@TimvdLippe

TimvdLippe Nov 19, 2018
Contributor

Per my review comment, adding the following should fix that:

/**
  * @this {HTMLElement}
  */

This comment has been minimized.

@TechQuery

TechQuery Nov 20, 2018
Author

I have tried to add @this, but nothing changed...

tests/parent-child-node.html Outdated Show resolved Hide resolved
tests/parent-child-node.html Outdated Show resolved Hide resolved
tests/parent-child-node.html Outdated Show resolved Hide resolved
src/patch-builtins.js Show resolved Hide resolved

const fragment = document.createDocumentFragment();

for (let node of list)

This comment has been minimized.

@TimvdLippe

TimvdLippe Nov 19, 2018
Contributor

Braces here as well.

package.json Outdated Show resolved Hide resolved
.editorconfig Outdated Show resolved Hide resolved
src/patch-builtins.js Outdated Show resolved Hide resolved
tests/parent-child-node.html Outdated Show resolved Hide resolved
@dfreedm dfreedm added this to Inbox in Polyfills Mar 18, 2019
@dfreedm
Copy link
Contributor

@dfreedm dfreedm commented Jun 10, 2019

Sorry for the long delay.

If this issue is still important for you, could you please remake this PR in the new monorepo: https://github.com/webcomponents/polyfills?

Thanks!

@dfreedm dfreedm closed this Jun 10, 2019
Polyfills automation moved this from Inbox to Done Jun 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Polyfills
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants