[ Add ] Utility methods of ParentNode & ChildNode interfaces - #294
[ Add ] Utility methods of ParentNode & ChildNode interfaces#294TechQuery wants to merge 5 commits into
Conversation
TimvdLippe
left a comment
TimvdLippe
left a comment
There was a problem hiding this comment.
Please add braces to all if-statements. Also, please add regression tests for these methods.
|
@TimvdLippe |
TimvdLippe
left a comment
TimvdLippe
left a comment
There was a problem hiding this comment.
I think all methods need the following JSdoc notation:
/**
* @this {HTMLElement}
*/This is also going to clash with #298, but I think it is better to wait for that PR to land before going ahead with this one.
| <script> | ||
| ShadyDOM = {force: true}; | ||
| </script> | ||
| <!-- <script src="../shadydom.min.js"></script> --> |
There was a problem hiding this comment.
Per my review comment, adding the following should fix that:
/**
* @this {HTMLElement}
*/There was a problem hiding this comment.
I have tried to add @this, but nothing changed...
|
|
||
| const fragment = document.createDocumentFragment(); | ||
|
|
||
| for (let node of list) |
|
Sorry for the long delay. If this issue is still important for you, could you please remake this PR in the new monorepo: https://github.com/webcomponents/polyfills? Thanks! |
3 participants
Reference Issue
Fixes #288