New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misdetection of native HTMLImports on Firefox for Android #452

Closed
KitaitiMakoto opened this Issue Nov 22, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@KitaitiMakoto
Copy link

KitaitiMakoto commented Nov 22, 2015

Hi,

Now detection of native HTMLImports is done here:

var useNative = Boolean(IMPORT_LINK_TYPE in document.createElement('link'));

But on Firefox for Android which, IMPORT_LINK_TYPE in document.createElement('link') is true although it doesn't support HTMLImports natively, because document.createElement('link').import is null object.

Could you implement more proper detection?

My environment is:
Device: Nexus 7 2013
OS: Android 6.0
Browser: Firefox for Android 42.0.1

Thank you.

@prantlf

This comment has been minimized.

Copy link

prantlf commented Dec 31, 2015

I observe the same behaviour in the desktop Firefox, if I set 'dom.webcomponents.enabled' to true in about:config. The import property exists and is null. Resetting the 'dom.webcomponents.enabled' to the default false helps.

Firefox wasn't planing to implement HTML Imports last year. The task in their bugzilla was set to "FIXED", but I don't know how to test it. The 'dom.webcomponents.enabled' alone is no way - it even breaks the webcomponents polyfill.

@ebidel

This comment has been minimized.

Copy link
Member

ebidel commented Dec 31, 2015

Please turn the flash off. Their implementation is incomplete. Checking for
the .import property is the right feature detect.

On Thu, Dec 31, 2015, 8:22 AM Ferdinand Prantl notifications@github.com
wrote:

I observe the same behaviour in the desktop Firefox, if I set
'dom.webcomponents.enabled' to true in about:config. The import property
exists and is null. Resetting the 'dom.webcomponents.enabled' to the
default false helps.

Firefox wasn't planing to implement HTML Imports last year
https://hacks.mozilla.org/2014/12/mozilla-and-web-components/. The task
in their bugzilla
https://hg.mozilla.org/integration/mozilla-inbound/rev/89716e3f169d was
set to "FIXED", bug I don't know how to test test it. The
'dom.webcomponents.enabled' alone is no way - it even breaks the
webcomponents polyfill.


Reply to this email directly or view it on GitHub
#452 (comment)
.

@ebidel ebidel closed this Dec 31, 2015

@KitaitiMakoto

This comment has been minimized.

Copy link

KitaitiMakoto commented Jan 1, 2016

I see. Thank you for the reply and sorry for bothering you.

@prantlf

This comment has been minimized.

Copy link

prantlf commented Jan 1, 2016

I've had Flash blocked and turning it off makes no change. (I'm not sure about the connection to the imports.)

Anyway, the 'dom.webcomponents.enabled' appears to be useless for the typical webcomponents use case and it should stay at its default false. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment