New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Opera Mini #146

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@fflewddur

fflewddur commented Jun 22, 2014

Opera Mini and some other mobile browsers use servers to process JavaScript, then send the result back to the device. Devices like these don't support the Scroll event, so I added a check to the constructor that verifies the browser supports 'onscroll'. If it doesn't, we won't hide the manual pagination link. This allows the plugin to fail gracefully on low-power mobile devices.

I've only been able to test this with Opera Mini for iOS, so verification that it works on other devices/browsers would be appreciated.

@fieg

This comment has been minimized.

Member

fieg commented Jun 26, 2014

Thank you for your PR. I think the detection code could should be placed in the initialize method around here. I will implement it some other time when I have some more time on my hands.

@fflewddur

This comment has been minimized.

fflewddur commented Jun 26, 2014

Ah, good point. If you don't beat me to it, I'll adjust my branch later this week and update the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment