From 0f541cd9222e782d85605d595d1e7b5851e59339 Mon Sep 17 00:00:00 2001 From: Ignacio Galindo Date: Tue, 16 Aug 2016 10:59:53 +0200 Subject: [PATCH 1/7] Put back codeclimate analysis, (shame, shame, shame) --- .codeclimate.yml | 32 +++++++ .eslintrc | 213 +++++++++++++++++++++++++++++++++++++++++++++++ README.md | 3 +- 3 files changed, 247 insertions(+), 1 deletion(-) create mode 100644 .codeclimate.yml create mode 100644 .eslintrc diff --git a/.codeclimate.yml b/.codeclimate.yml new file mode 100644 index 0000000..8a4842a --- /dev/null +++ b/.codeclimate.yml @@ -0,0 +1,32 @@ +--- +engines: + bundler-audit: + enabled: true + coffelint: + enabled: true + csslint: + enabled: true + eslint: + enabled: true + channel: eslint-2 + duplication: + enabled: true + config: + languages: + - ruby + - javascript + rubocop: + enabled: true + ratings: + enabled: true + paths: + - Gemfile.lock + - app/** + - lib/** + - "**.js" + - "**.rb" +exclude_paths: + - bin/** + - spec/** + - UI/** + - vendor/** diff --git a/.eslintrc b/.eslintrc new file mode 100644 index 0000000..9faa375 --- /dev/null +++ b/.eslintrc @@ -0,0 +1,213 @@ +ecmaFeatures: + modules: true + jsx: true + +env: + amd: true + browser: true + es6: true + jquery: true + node: true + +# http://eslint.org/docs/rules/ +rules: + # Possible Errors + comma-dangle: [2, never] + no-cond-assign: 2 + no-console: 0 + no-constant-condition: 2 + no-control-regex: 2 + no-debugger: 2 + no-dupe-args: 2 + no-dupe-keys: 2 + no-duplicate-case: 2 + no-empty: 2 + no-empty-character-class: 2 + no-ex-assign: 2 + no-extra-boolean-cast: 2 + no-extra-parens: 0 + no-extra-semi: 2 + no-func-assign: 2 + no-inner-declarations: [2, functions] + no-invalid-regexp: 2 + no-irregular-whitespace: 2 + no-negated-in-lhs: 2 + no-obj-calls: 2 + no-regex-spaces: 2 + no-sparse-arrays: 2 + no-unexpected-multiline: 2 + no-unreachable: 2 + use-isnan: 2 + valid-jsdoc: 0 + valid-typeof: 2 + + # Best Practices + accessor-pairs: 2 + block-scoped-var: 0 + complexity: [2, 6] + consistent-return: 0 + curly: 0 + default-case: 0 + dot-location: 0 + dot-notation: 0 + eqeqeq: 2 + guard-for-in: 2 + no-alert: 2 + no-caller: 2 + no-case-declarations: 2 + no-div-regex: 2 + no-else-return: 0 + no-empty-label: 2 + no-empty-pattern: 2 + no-eq-null: 2 + no-eval: 2 + no-extend-native: 2 + no-extra-bind: 2 + no-fallthrough: 2 + no-floating-decimal: 0 + no-implicit-coercion: 0 + no-implied-eval: 2 + no-invalid-this: 0 + no-iterator: 2 + no-labels: 0 + no-lone-blocks: 2 + no-loop-func: 2 + no-magic-number: 0 + no-multi-spaces: 0 + no-multi-str: 0 + no-native-reassign: 2 + no-new-func: 2 + no-new-wrappers: 2 + no-new: 2 + no-octal-escape: 2 + no-octal: 2 + no-proto: 2 + no-redeclare: 2 + no-return-assign: 2 + no-script-url: 2 + no-self-compare: 2 + no-sequences: 0 + no-throw-literal: 0 + no-unused-expressions: 2 + no-useless-call: 2 + no-useless-concat: 2 + no-void: 2 + no-warning-comments: 0 + no-with: 2 + radix: 2 + vars-on-top: 0 + wrap-iife: 2 + yoda: 0 + + # Strict + strict: 0 + + # Variables + init-declarations: 0 + no-catch-shadow: 2 + no-delete-var: 2 + no-label-var: 2 + no-shadow-restricted-names: 2 + no-shadow: 0 + no-undef-init: 2 + no-undef: 0 + no-undefined: 0 + no-unused-vars: 0 + no-use-before-define: 0 + + # Node.js and CommonJS + callback-return: 2 + global-require: 2 + handle-callback-err: 2 + no-mixed-requires: 0 + no-new-require: 0 + no-path-concat: 2 + no-process-exit: 2 + no-restricted-modules: 0 + no-sync: 0 + + # Stylistic Issues + array-bracket-spacing: 0 + block-spacing: 0 + brace-style: 0 + camelcase: 0 + comma-spacing: 0 + comma-style: 0 + computed-property-spacing: 0 + consistent-this: 0 + eol-last: 0 + func-names: 0 + func-style: 0 + id-length: 0 + id-match: 0 + indent: 0 + jsx-quotes: 0 + key-spacing: 0 + linebreak-style: 0 + lines-around-comment: 0 + max-depth: 0 + max-len: 0 + max-nested-callbacks: 0 + max-params: 0 + max-statements: [2, 30] + new-cap: 0 + new-parens: 0 + newline-after-var: 0 + no-array-constructor: 0 + no-bitwise: 0 + no-continue: 0 + no-inline-comments: 0 + no-lonely-if: 0 + no-mixed-spaces-and-tabs: 0 + no-multiple-empty-lines: 0 + no-negated-condition: 0 + no-nested-ternary: 0 + no-new-object: 0 + no-plusplus: 0 + no-restricted-syntax: 0 + no-spaced-func: 0 + no-ternary: 0 + no-trailing-spaces: 0 + no-underscore-dangle: 0 + no-unneeded-ternary: 0 + object-curly-spacing: 0 + one-var: 0 + operator-assignment: 0 + operator-linebreak: 0 + padded-blocks: 0 + quote-props: 0 + quotes: 0 + require-jsdoc: 0 + semi-spacing: 0 + semi: 0 + sort-vars: 0 + space-after-keywords: 0 + space-before-blocks: 0 + space-before-function-paren: 0 + space-before-keywords: 0 + space-in-parens: 0 + space-infix-ops: 0 + space-return-throw-case: 0 + space-unary-ops: 0 + spaced-comment: 0 + wrap-regex: 0 + + # ECMAScript 6 + arrow-body-style: 0 + arrow-parens: 0 + arrow-spacing: 0 + constructor-super: 0 + generator-star-spacing: 0 + no-arrow-condition: 0 + no-class-assign: 0 + no-const-assign: 0 + no-dupe-class-members: 0 + no-this-before-super: 0 + no-var: 0 + object-shorthand: 0 + prefer-arrow-callback: 0 + prefer-const: 0 + prefer-reflect: 0 + prefer-spread: 0 + prefer-template: 0 + require-yield: 0 diff --git a/README.md b/README.md index e4e7865..608262e 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,8 @@ # About [![travis](https://img.shields.io/travis/webdevtalks/www.svg)](https://travis-ci.org/webdevtalks/www) -[![coveralls](https://img.shields.io/coveralls/webdevtalks/www.svg?maxAge=2592000)](https://coveralls.io/github/webdevtalks/www) +[![codeclimate](https://codeclimate.com/github/webdevtalks/www/badges/gpa.svg)](https://codeclimate.com/github/webdevtalks/www) +[![coveralls](https://img.shields.io/coveralls/webdevtalks/www.svg)](https://coveralls.io/github/webdevtalks/www) # Setup From 4ea3a3ecdde99a323198ecf3a7c833b20f9a2785 Mon Sep 17 00:00:00 2001 From: Ignacio Galindo Date: Tue, 16 Aug 2016 12:19:46 +0200 Subject: [PATCH 2/7] Ignore codeclimate analysis on db directory --- .codeclimate.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.codeclimate.yml b/.codeclimate.yml index 8a4842a..a286295 100644 --- a/.codeclimate.yml +++ b/.codeclimate.yml @@ -27,6 +27,7 @@ engines: - "**.rb" exclude_paths: - bin/** + - db/** - spec/** - UI/** - vendor/** From ce2f5aa293abdc6246d51b0685754f3983d9dc3d Mon Sep 17 00:00:00 2001 From: Ignacio Galindo Date: Tue, 16 Aug 2016 12:20:50 +0200 Subject: [PATCH 3/7] Also ignore public/assets from codeclimate analysis --- .codeclimate.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.codeclimate.yml b/.codeclimate.yml index a286295..fc33d7c 100644 --- a/.codeclimate.yml +++ b/.codeclimate.yml @@ -28,6 +28,7 @@ engines: exclude_paths: - bin/** - db/** + - public/assets/** - spec/** - UI/** - vendor/** From 454096544126e20950460cd52fae3633c8250b2c Mon Sep 17 00:00:00 2001 From: Ignacio Galindo Date: Tue, 16 Aug 2016 12:40:23 +0200 Subject: [PATCH 4/7] Ignore asset manifest files from codeclimate --- .codeclimate.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.codeclimate.yml b/.codeclimate.yml index fc33d7c..9b65704 100644 --- a/.codeclimate.yml +++ b/.codeclimate.yml @@ -26,6 +26,7 @@ engines: - "**.js" - "**.rb" exclude_paths: + - app/assets/javascripts/{app,admin}.js - bin/** - db/** - public/assets/** From fc2617d39b28cf8120c06abfdefcf1010c653ff7 Mon Sep 17 00:00:00 2001 From: Ignacio Galindo Date: Tue, 16 Aug 2016 12:46:23 +0200 Subject: [PATCH 5/7] Vendor v1 javascript theme --- app/assets/javascripts/app.js | 2 +- .../app/vendors.js => vendor/assets/javascripts/theme.js | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename app/assets/javascripts/app/vendors.js => vendor/assets/javascripts/theme.js (100%) diff --git a/app/assets/javascripts/app.js b/app/assets/javascripts/app.js index 836e9ec..87cdc04 100644 --- a/app/assets/javascripts/app.js +++ b/app/assets/javascripts/app.js @@ -12,6 +12,6 @@ // //= require jquery //= require jquery_ujs -//= require app/vendors +//= require theme //= require app/base //= require app/home diff --git a/app/assets/javascripts/app/vendors.js b/vendor/assets/javascripts/theme.js similarity index 100% rename from app/assets/javascripts/app/vendors.js rename to vendor/assets/javascripts/theme.js From 18249c400cacef2c3f3c1da431d3ea426d50a0df Mon Sep 17 00:00:00 2001 From: Ignacio Galindo Date: Tue, 16 Aug 2016 13:03:35 +0200 Subject: [PATCH 6/7] Ignore asset manifest files from codeclimate (2) Withouth shell expansion --- .codeclimate.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.codeclimate.yml b/.codeclimate.yml index 9b65704..4112980 100644 --- a/.codeclimate.yml +++ b/.codeclimate.yml @@ -26,7 +26,8 @@ engines: - "**.js" - "**.rb" exclude_paths: - - app/assets/javascripts/{app,admin}.js + - app/assets/javascripts/admin.js + - app/assets/javascripts/app.js - bin/** - db/** - public/assets/** From 8b10ff109a696b0a7a7ad0dd8e34eee80d82b829 Mon Sep 17 00:00:00 2001 From: Ignacio Galindo Date: Tue, 16 Aug 2016 13:55:40 +0200 Subject: [PATCH 7/7] Fix eslint errors :D --- .eslintrc | 3 +-- app/assets/javascripts/app/base.js | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.eslintrc b/.eslintrc index 9faa375..78118f7 100644 --- a/.eslintrc +++ b/.eslintrc @@ -57,7 +57,7 @@ rules: no-case-declarations: 2 no-div-regex: 2 no-else-return: 0 - no-empty-label: 2 + no-labels: 2 no-empty-pattern: 2 no-eq-null: 2 no-eval: 2 @@ -69,7 +69,6 @@ rules: no-implied-eval: 2 no-invalid-this: 0 no-iterator: 2 - no-labels: 0 no-lone-blocks: 2 no-loop-func: 2 no-magic-number: 0 diff --git a/app/assets/javascripts/app/base.js b/app/assets/javascripts/app/base.js index 6ab5076..f4c9cde 100644 --- a/app/assets/javascripts/app/base.js +++ b/app/assets/javascripts/app/base.js @@ -100,4 +100,4 @@ wplook.startWpl(); }); -})(jQuery); +}(jQuery));