From 1d90ee8bc7db4ff889dcb480d92c6f91ed912be7 Mon Sep 17 00:00:00 2001 From: praveendvd <45095911+praveendvd@users.noreply.github.com> Date: Fri, 25 Jun 2021 17:56:26 +0100 Subject: [PATCH] Fix for chrome service failing for multi remote #7055 (#58) * Fix for chrome service failing for multi remote #7055 * Update launcher.js used logical AND operation * Added unit tests --- src/launcher.js | 4 ++-- tests/launcher.test.js | 10 ++++++++++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/launcher.js b/src/launcher.js index b99a54c..f260fa8 100644 --- a/src/launcher.js +++ b/src/launcher.js @@ -21,7 +21,7 @@ const DEFAULT_CONNECTION = { } const isMultiremote = obj => typeof obj === 'object' && !Array.isArray(obj) -const isChrome = cap => cap.browserName.toLowerCase() === 'chrome' +const isChrome = cap => cap.browserName && cap.browserName.toLowerCase() === 'chrome' export default class ChromeDriverLauncher { constructor(options, capabilities, config) { @@ -79,7 +79,7 @@ export default class ChromeDriverLauncher { process.on('uncaughtException', this.onComplete.bind(this)) } - onComplete () { + onComplete() { if (this.process) { this.process.kill() } diff --git a/tests/launcher.test.js b/tests/launcher.test.js index e559618..083263c 100644 --- a/tests/launcher.test.js +++ b/tests/launcher.test.js @@ -36,6 +36,11 @@ describe('ChromeDriverLauncher launcher', () => { capabilities: { browserName: 'firefox' } + }, + myCustomAppium: { + capabilities: { + 'platformName': 'android', + } } } }) @@ -200,6 +205,11 @@ describe('ChromeDriverLauncher launcher', () => { capabilities: { browserName: 'firefox' } + }, + myCustomAppium: { + capabilities: { + 'platformName': 'android', + } } }) })