Fixed checking font-weight returned an object, fixes #144

webdriverio · Oct 31, 2017 · 151cb2f · 151cb2f
1 parent df8ad2c
commit 151cb2f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/demo-app/index.html b/demo-app/index.html
@@ -69,7 +69,7 @@ <h1>DEMO APP</h1>
             <hr />
 
             <div id="attributeComparison" role="note">This element has a role attribute with the value "note"</div>
-            <div id="cssAttributeComparison" style="color:rgba(255,0,0,1)">This element has a color css attribute with the value "rgba(255,0,0,1)"</div>
+            <div id="cssAttributeComparison" style="color:rgba(255,0,0,1); font-weight: 700">This element has a color css attribute with the value "rgba(255,0,0,1)"</div>
 
             <hr />
 

diff --git a/src/features/attribute.feature b/src/features/attribute.feature
@@ -19,3 +19,6 @@ Feature: Test the attributes of a given element
 
     Scenario: The (missing) CSS attribute "border" of a element should not be "0"
         Then  I expect that the css attribute "border" from element "#cssAttributeComparison" is not "0"
+
+    Scenario: The CSS attribute "font-weight" of a element should be "bold"
+        Then  I expect that the css attribute "font-weight" from element "#cssAttributeComparison" is "bold"
diff --git a/src/support/check/checkProperty.js b/src/support/check/checkProperty.js
@@ -28,10 +28,10 @@ module.exports = (isCSS, attrName, elem, falseCase, expectedValue) => {
     let attributeValue = browser[command](elem, attrName);
 
     /**
-     * when getting something with a color WebdriverIO returns a color
+     * when getting something with a color or font-weight WebdriverIO returns a
      * object but we want to assert against a string
      */
-    if (attrName.indexOf('color') > -1) {
+    if (attrName.match(/(color|font-weight)/)) {
         attributeValue = attributeValue.value;
     }