Skip to content

fix(disableBlinkingCursor): caret-color was not applied in shadowdom … #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wswebcreation merged 1 commit into from
Nov 29, 2025
Merged

fix(disableBlinkingCursor): caret-color was not applied in shadowdom … #1079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/blinking-cursor-shadowdom.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@wdio/visual-service": patch
---

Fix option "disableBlinkingCursor" to also work within shadowdom
2 changes: 1 addition & 1 deletion packages/image-comparison-core/src/clientSideScripts/__snapshots__/setCustomCss.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ exports[`setCustomCss > should be able to set the custom css with the default op

exports[`setCustomCss > should be able to set the custom css with the with disableBlinkingCursor set to true 1`] = `""`;

exports[`setCustomCss > should be able to set the custom css with the with disableBlinkingCursor set to true 2`] = `" input, textarea, [contenteditable]{caret-color: transparent !important;}"`;
exports[`setCustomCss > should be able to set the custom css with the with disableBlinkingCursor set to true 2`] = `" *{caret-color: transparent !important;}"`;

exports[`setCustomCss > should be able to set the custom css with the with padding set to 0 1`] = `""`;

Expand Down
2 changes: 1 addition & 1 deletion packages/image-comparison-core/src/clientSideScripts/setCustomCss.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default function setCustomCss(cssOptions: CssOptions): void {
const { addressBarPadding, disableBlinkingCursor, disableCSSAnimation, id, toolBarPadding } = cssOptions
const bodyTopPadding = addressBarPadding === 0 ? '' : `body{padding-top:${addressBarPadding}px !important}`
const bodyBottomPadding = toolBarPadding === 0 ? '' : `body{padding-bottom:${toolBarPadding}px !important}`
const disableBlinkingCursorCss = disableBlinkingCursor ? ' input, textarea, [contenteditable]{caret-color: transparent !important;}' : ''
const disableBlinkingCursorCss = disableBlinkingCursor ? ' *{caret-color: transparent !important;}' : ''
const css = (disableCSSAnimation ? disableTransformationsTransitionsAnimations : '') +
bodyTopPadding +
bodyBottomPadding +
Expand Down
Loading