From 1eb72c40868f4a1cb17c896d2a234c69e0528541 Mon Sep 17 00:00:00 2001 From: "denise.ribeiro" Date: Tue, 23 Nov 2021 16:22:09 -0300 Subject: [PATCH] Fix preferScenarioName option to be applicable for all scenarios with status different of skipped. --- packages/wdio-browserstack-service/src/service.ts | 2 +- packages/wdio-browserstack-service/tests/service.test.ts | 9 ++------- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/packages/wdio-browserstack-service/src/service.ts b/packages/wdio-browserstack-service/src/service.ts index 44808429896..b044b2d7605 100644 --- a/packages/wdio-browserstack-service/src/service.ts +++ b/packages/wdio-browserstack-service/src/service.ts @@ -121,7 +121,7 @@ export default class BrowserstackService implements Services.ServiceInstance { */ afterScenario (world: Frameworks.World) { const status = world.result?.status.toLowerCase() - if (status === 'skipped') { + if (status !== 'skipped') { this._scenariosThatRan.push(world.pickle.name || 'unknown pickle name') } diff --git a/packages/wdio-browserstack-service/tests/service.test.ts b/packages/wdio-browserstack-service/tests/service.test.ts index bae1b7ba72d..8f649959956 100644 --- a/packages/wdio-browserstack-service/tests/service.test.ts +++ b/packages/wdio-browserstack-service/tests/service.test.ts @@ -670,13 +670,8 @@ describe('after', () => { describe('enabled', () => { [ { status: 'FAILED', body: { - name: 'Feature1', - reason: 'Unknown Error', - status: 'failed', - } }, - { status: 'SKIPPED', body: { name: 'Can do something single', - reason: undefined, + reason: 'Unknown Error', status: 'failed', } } /*, 5, 4, 0*/ @@ -705,7 +700,7 @@ describe('after', () => { await service.beforeFeature(null, { name: 'Feature1' }) - await service.afterScenario({ pickle: { name: 'Can do something single' }, result: { status: 'SKIPPED' } }) + await service.afterScenario({ pickle: { name: 'Can do something single' }, result: { status: 'passed' } }) await service.after(0)