From c4def4c0db58edb2109a8b0c810f01ab73b730aa Mon Sep 17 00:00:00 2001 From: Christian Bromann Date: Sat, 14 Dec 2019 13:35:41 -0500 Subject: [PATCH] Minor cleanup to avoid `getSpecs` call (#4881) --- packages/wdio-cli/src/interface.js | 3 +-- packages/wdio-cli/src/launcher.js | 3 +-- packages/wdio-cli/tests/interface.test.js | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/packages/wdio-cli/src/interface.js b/packages/wdio-cli/src/interface.js index 5fe571f851c..87c214c1932 100644 --- a/packages/wdio-cli/src/interface.js +++ b/packages/wdio-cli/src/interface.js @@ -7,7 +7,7 @@ import { getRunnerName } from './utils' const log = logger('@wdio/cli') export default class WDIOCLInterface extends EventEmitter { - constructor (config, specs, totalWorkerCnt, isWatchMode = false) { + constructor (config, totalWorkerCnt, isWatchMode = false) { super() /** @@ -16,7 +16,6 @@ export default class WDIOCLInterface extends EventEmitter { * `FORCE_COLOR=0` - forcibly disable colors */ this.hasAnsiSupport = !!chalk.supportsColor.hasBasic - this.specs = specs this.config = config this.totalWorkerCnt = totalWorkerCnt this.isWatchMode = isWatchMode diff --git a/packages/wdio-cli/src/launcher.js b/packages/wdio-cli/src/launcher.js index f8b8a6cda76..c6573395154 100644 --- a/packages/wdio-cli/src/launcher.js +++ b/packages/wdio-cli/src/launcher.js @@ -22,7 +22,6 @@ class Launcher { const config = this.configParser.getConfig() const capabilities = this.configParser.getCapabilities() - const specs = this.configParser.getSpecs() this.isWatchMode = isWatchMode @@ -42,7 +41,7 @@ class Launcher { const Runner = initialisePlugin(config.runner, 'runner') this.runner = new Runner(configFilePath, config) - this.interface = new CLInterface(config, specs, totalWorkerCnt, this.isWatchMode) + this.interface = new CLInterface(config, totalWorkerCnt, this.isWatchMode) config.runnerEnv.FORCE_COLOR = Number(this.interface.hasAnsiSupport) this.isMultiremote = !Array.isArray(capabilities) diff --git a/packages/wdio-cli/tests/interface.test.js b/packages/wdio-cli/tests/interface.test.js index 32221cc98ba..6715b428f79 100644 --- a/packages/wdio-cli/tests/interface.test.js +++ b/packages/wdio-cli/tests/interface.test.js @@ -2,14 +2,13 @@ import WDIOCLInterface from '../src/interface' import chalk from 'chalk' const config = {} -const specs = ['/some/path/to/test.js'] global.console.log = jest.fn() describe('cli interface', () => { let wdioClInterface beforeEach(() => { - wdioClInterface = new WDIOCLInterface(config, specs, 5) + wdioClInterface = new WDIOCLInterface(config, 5) wdioClInterface.log = jest.fn().mockImplementation((...args) => args) })