Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isClickable handles child elements #4754

Merged

Conversation

@mgrybyk
Copy link
Member

mgrybyk commented Nov 8, 2019

Proposed changes

is clickable should return true if elementFromPoint is child of target element

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Reviewers: @webdriverio/technical-committee

@igerasimov23

This comment has been minimized.

Copy link

igerasimov23 commented Nov 8, 2019

Thank you for quick fix. I executed one test and looks fine to me!

Copy link
Member

christian-bromann left a comment

👍

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #4754 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4754   +/-   ##
======================================
  Coverage    99.4%   99.4%           
======================================
  Files         210     210           
  Lines        5419    5419           
  Branches     1179    1179           
======================================
  Hits         5387    5387           
  Misses         29      29           
  Partials        3       3
Impacted Files Coverage Δ
packages/wdio-cucumber-framework/src/index.js 98.82% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59e11c0...a1697a2. Read the comment docs.

Copy link
Member

christian-bromann left a comment

👍

@christian-bromann christian-bromann merged commit 818d057 into webdriverio:master Nov 8, 2019
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing 59e11c0...a1697a2
Details
codecov/project 99.4% remains the same compared to 59e11c0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.