Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sessionId to normal capabilities for spec-reporter #4843

Conversation

@Smashman
Copy link
Contributor

Smashman commented Dec 2, 2019

Proposed changes

Add sessionId to capabilities to allow the spec-reporter to add the ID to the report.
Further from discussion on #4834 with @christian-bromann.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/technical-committee

@jsf-clabot

This comment has been minimized.

Copy link

jsf-clabot commented Dec 2, 2019

CLA assistant check
All committers have signed the CLA.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #4843 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4843   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files         209      209           
  Lines        5454     5454           
  Branches     1193     1193           
=======================================
  Hits         5421     5421           
  Misses         30       30           
  Partials        3        3
Impacted Files Coverage Δ
packages/wdio-runner/src/index.js 97.43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebea222...01ae3f5. Read the comment docs.

@christian-bromann christian-bromann merged commit 55a5415 into webdriverio:master Dec 2, 2019
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing ebea222...01ae3f5
Details
codecov/project 99.39% remains the same compared to ebea222
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.