Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Chrome refs type (#4989) #4990

Merged
merged 2 commits into from Feb 10, 2020
Merged

Conversation

@lamkovod
Copy link
Contributor

lamkovod commented Feb 3, 2020

Proposed changes

Just small fix for ChromeOptions refs.
Documentation: https://chromedriver.chromium.org/capabilities

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Further comments

#4989

Reviewers: @webdriverio/technical-committee

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #4990 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4990   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files         210      210           
  Lines        5504     5504           
  Branches     1178     1178           
=======================================
  Hits         5472     5472           
  Misses         29       29           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a69a3e5...6e308d4. Read the comment docs.

@lamkovod lamkovod requested a review from christian-bromann Feb 4, 2020
Copy link
Member

christian-bromann left a comment

Thanks! 👍

@christian-bromann christian-bromann merged commit 30ff73e into webdriverio:master Feb 10, 2020
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing a69a3e5...6e308d4
Details
codecov/project 99.41% remains the same compared to a69a3e5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
christian-bromann added a commit that referenced this pull request Feb 14, 2020
* Fix for Chrome refs type (#4989)

* Test Chrome Firefox Config type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.