Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add click options #5005

Merged
merged 2 commits into from Feb 11, 2020
Merged

Add click options #5005

merged 2 commits into from Feb 11, 2020

Conversation

@christian-bromann
Copy link
Member

christian-bromann commented Feb 10, 2020

Proposed changes

Closes #4735

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/technical-committee

@christian-bromann christian-bromann requested a review from webdriverio/project-committers Feb 10, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #5005 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5005   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files         210      210           
  Lines        5509     5509           
  Branches     1180     1180           
=======================================
  Hits         5477     5477           
  Misses         29       29           
  Partials        3        3
Impacted Files Coverage Δ
packages/webdriverio/src/commands/element/click.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d6913f...7b4205e. Read the comment docs.

Copy link
Member

erwinheitzman left a comment

The object would now always be required, we should make passing the object optional as stated in the description

Copy link
Member

mgrybyk left a comment

please generate types

@christian-bromann christian-bromann force-pushed the cb-add-click-options branch from 20608b8 to 7b4205e Feb 11, 2020
@christian-bromann

This comment has been minimized.

Copy link
Member Author

christian-bromann commented Feb 11, 2020

@erwinheitzman @mgrybyk I generated typings, anything left?

@christian-bromann christian-bromann dismissed erwinheitzman’s stale review Feb 11, 2020

addressed comments

@christian-bromann christian-bromann merged commit 2a270b6 into master Feb 11, 2020
6 checks passed
6 checks passed
License Compliance All checks passed.
Details
codecov/patch Coverage not affected when comparing 2d6913f...7b4205e
Details
codecov/project 99.41% remains the same compared to 2d6913f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@christian-bromann christian-bromann deleted the cb-add-click-options branch Feb 11, 2020
christian-bromann added a commit that referenced this pull request Feb 14, 2020
* add click options

* generated typings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.