Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type definition for Sauce Labs capabilities #6474

Merged
merged 1 commit into from Feb 18, 2021
Merged

Improve type definition for Sauce Labs capabilities #6474

merged 1 commit into from Feb 18, 2021

Conversation

christian-bromann
Copy link
Member

Proposed changes

I added some docs for the Sauce Labs capability types.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label Feb 18, 2021
@christian-bromann christian-bromann requested a review from a team February 18, 2021 10:15
wswebcreation
wswebcreation approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@wswebcreation wswebcreation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this

@christian-bromann christian-bromann merged commit 2714a42 into main Feb 18, 2021
@christian-bromann christian-bromann deleted the cb-better-sauce-types branch February 18, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wswebcreation wswebcreation wswebcreation approved these changes

Assignees
No one assigned
Labels
PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@christian-bromann @wswebcreation