New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified globalSetup.ts to make reason and origin of throwBetterErrorMessage more clear #9336
Modified globalSetup.ts to make reason and origin of throwBetterErrorMessage more clear #9336
Conversation
…Message more clear
👍
Can we have it so we have less duplicate text, e.g. using const ERROR_MESSAGE = '...%s...'
console.log(util.format(ERROR_MESSAGE, 'teardown') I hope that illustrates the approach I mean. |
Yep, fair enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thank you |
Proposed changes
In working with the WebdriverIO testing, I tried to use the ViTest extension to VSCode and when I ran it I got the error message about having to rename "got". I wasn't really sure where it was coming from and because I had successfully run the tests in a terminal decided that it must being caused by the ViTest plugin or VS Code. Then I realised that the tests would not run in my terminal any more and I got the same error.
The key change is to change "We" to "WebdriverIO", which hopefully makes it clearer where the source of the error is. I have also created a separate message for Setup and TearDown and made them slightly more descriptive of what is happening.
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers