Skip to content

Commit 08b3ab6

Browse files
committed
fix(rooms): seperate acitivities id from room id
1 parent ef33a64 commit 08b3ab6

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

src/adapters/RoomsJSONAdapter.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export default class RoomsJSONAdapter extends RoomsAdapter {
5555
*/
5656
getPreviousRoomActivities(ID) {
5757
return Observable.create((observer) => {
58-
const data = !this.datasource[ID] ? [] : this.datasource[ID];
58+
const data = !this.datasource[`${ID}-activities`] ? [] : this.datasource[`${ID}-activities`];
5959

6060
observer.next(data);
6161

@@ -72,7 +72,7 @@ export default class RoomsJSONAdapter extends RoomsAdapter {
7272
*/
7373
getRoomActivities(ID) {
7474
return Observable.create((observer) => {
75-
const data = !this.datasource[ID] ? [] : this.datasource[ID];
75+
const data = !this.datasource[`${ID}-activities`] ? [] : this.datasource[`${ID}-activities`];
7676

7777
observer.next(data);
7878

src/adapters/RoomsJSONAdapter.test.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,18 @@ import rooms from './../data/rooms';
22
import RoomsJSONAdapter from './RoomsJSONAdapter';
33

44
describe('Rooms JSON Adapter Interface', () => {
5-
let roomsJSONAdapter, roomID, roomActivitiesID;
5+
let roomsJSONAdapter, roomID;
66

77
beforeEach(() => {
8-
[roomID, roomActivitiesID] = Object.keys(rooms);
8+
[roomID] = Object.keys(rooms);
99
roomsJSONAdapter = new RoomsJSONAdapter(rooms);
1010
});
1111

1212
test('getRoom() returns an observable', () => {
1313
expect(rxjs.isObservable(roomsJSONAdapter.getRoom())).toBeTruthy();
1414
});
1515

16-
test('getRoom() returns a person data', (done) => {
16+
test('getRoom() returns a room data', (done) => {
1717
roomsJSONAdapter.getRoom(roomID).subscribe((data) => {
1818
expect(data).toEqual(rooms[roomID]);
1919
done();
@@ -48,8 +48,8 @@ describe('Rooms JSON Adapter Interface', () => {
4848
});
4949

5050
test('getPreviousRoomActivities() returns an array of previous activity IDs', (done) => {
51-
roomsJSONAdapter.getPreviousRoomActivities(roomActivitiesID).subscribe((data) => {
52-
expect(data).toEqual(rooms[roomActivitiesID]);
51+
roomsJSONAdapter.getPreviousRoomActivities(roomID).subscribe((data) => {
52+
expect(data).toEqual(rooms[`${roomID}-activities`]);
5353
done();
5454
});
5555
});
@@ -79,8 +79,8 @@ describe('Rooms JSON Adapter Interface', () => {
7979
});
8080

8181
test('getRoomActivities() returns an array of previous activity IDs', (done) => {
82-
roomsJSONAdapter.getRoomActivities(roomActivitiesID).subscribe((data) => {
83-
expect(data).toEqual(rooms[roomActivitiesID]);
82+
roomsJSONAdapter.getRoomActivities(roomID).subscribe((data) => {
83+
expect(data).toEqual(rooms[`${roomID}-activities`]);
8484
done();
8585
});
8686
});

src/adapters/index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,4 @@ export {default as PeopleJSONAdapter} from './PeopleJSONAdapter';
44
export {default as ActivitiesAdapter} from './ActivitiesAdapter';
55
export {default as ActivitiesJSONAdapter} from './ActivitiesJSONAdapter';
66
export {default as RoomsAdapter} from './RoomsAdapter';
7+
export {default as RoomsJSONAdapter} from './RoomsJSONAdapter';

0 commit comments

Comments
 (0)