feat(peopleadapter): init with json data

Author: adamweeks

src/adapters/PeopleJSONAdapter.js

@@ -1,21 +1,43 @@
 import {Observable} from 'rxjs';
 
-import person from './../data/person';
 import PeopleAdapter from './PeopleAdapter';
 
 export default class PeopleJSONAdapter extends PeopleAdapter {
   /**
-   * Returns an observable that emits person data.
-   * Person data comes from JSON file `person.json` in the data folder.
+   * @typedef PeopleJSON
+   * @param {object} datasource An object that contains a set of people keyed by ID.
+   * @example
+   * {
+   *   "userid-1": {
+   *     "ID": "userid-1",
+   *     "emails": [
+   *       "webexcmps@gmail.com"
+   *     ],
+   *     "displayName": "Webex Component User",
+   *     "firstName": "Webex",
+   *     "LastName": "Component User",
+   *     "nickName": "Webex",
+   *     "avatar": "https://4b4dc97add6b1dcc891a-54bf3b4e4579920861d23cc001530c2a.ssl.cf1.rackcdn.com/V1~b33cb17c-42e3-41ac-a045-497e4002646c~697607d5347442a990719dd5d80ce379~1600",
+   *     "orgID": "Y2lzY29zcGFyazovL3VzL09SR0FOSVpBVElPTi9jb25zdW1lcg",
+   *     "status": "unknown"
+   *    }
+   * }
+   */
+
+  /**
+   * Returns an observable that emits person data of the given ID.
    *
-   * @param {String} id - ID of person to get
-   * @returns {Observable<PersonObject>}
+   * @param {string} ID ID of person to get
+   * @returns {Observable.<Person>}
    * @memberof PeopleJSONAdapter
    */
-  getPerson(id) {
+  getPerson(ID) {
     return Observable.create((observer) => {
-      if (person.id === id) observer.next(person);
-      else observer.error(new Error(`Could not find person with id "${id}"`));
+      if (this.datasource[ID]) {
+        observer.next(this.datasource[ID]);
+      } else {
+        observer.error(new Error(`Could not find person with ID "${ID}"`));
+      }
 
       observer.complete();
     });

src/adapters/PeopleJSONAdapter.test.js

@@ -2,18 +2,20 @@ import person from './../data/person';
 import PeopleJSONAdapter from './PeopleJSONAdapter';
 
 describe('People Adapter Interface', () => {
-  let peopleJSONAdapter;
+  let peopleJSONAdapter, peopleJSON;
 
   beforeEach(() => {
-    peopleJSONAdapter = new PeopleJSONAdapter();
+    peopleJSON = {};
+    peopleJSON[person.ID] = person;
+    peopleJSONAdapter = new PeopleJSONAdapter(peopleJSON);
   });
 
   test('getPerson() returns an observable', () => {
     expect(rxjs.isObservable(peopleJSONAdapter.getPerson())).toBeTruthy();
   });
 
   test('getPerson() returns a person data', (done) => {
-    peopleJSONAdapter.getPerson(person.id).subscribe((data) => {
+    peopleJSONAdapter.getPerson(person.ID).subscribe((data) => {
       expect(data).toEqual(person);
       done();
     });
@@ -25,14 +27,14 @@ describe('People Adapter Interface', () => {
     peopleJSONAdapter.getPerson(personID).subscribe(
       () => {},
       (error) => {
-        expect(error.message).toBe(`Could not find person with id "${personID}"`);
+        expect(error.message).toBe(`Could not find person with ID "${personID}"`);
         done();
       }
     );
   });
 
   test('getPerson() completes the observable', (done) => {
-    peopleJSONAdapter.getPerson(person.id).subscribe(
+    peopleJSONAdapter.getPerson(person.ID).subscribe(
       () => {},
       () => {},
       () => {