fix: Meeting Title margin issue in in-meeting component #844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreenara
approved these changes
Oct 16, 2024
| background: var(--wxc-secondary-video-background); | ||
| } | ||
|
|
||
| .#{$C}__info { |
Contributor
There was a problem hiding this comment.
Why is this name formatted this way?
Contributor
Author
There was a problem hiding this comment.
$C:
they just used 'C' as variable for below
#{$WEBEX_COMPONENTS_CLASS_PREFIX}-in-meeting;
final string is : webex-in-meeting__info
'__info' : Its an element
Element: An element is a part of the block that has no standalone meaning and is semantically tied to its block. Elements are denoted by double underscores (__). For example, info is an element of the block.(Chat GPT :))
sreenara
approved these changes
Oct 16, 2024
Shreyas281299
approved these changes
Oct 16, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
## [1.275.2](v1.275.1...v1.275.2) (2024-10-16) ### Bug Fixes * Meeting Title margin issue in in-meeting component ([#844](#844)) ([46cbb99](46cbb99))
|
🎉 This PR is included in version 1.275.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Meeting Title in in-meeting component is not rendered as per web.webex.com
fix: added info with margin in in-meeting css
screenshot before:
screenshot after:
