Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newer Symfony versions compatibility #11

Closed
FabianSchmick opened this issue Dec 20, 2018 · 5 comments · Fixed by #12
Closed

Newer Symfony versions compatibility #11

FabianSchmick opened this issue Dec 20, 2018 · 5 comments · Fixed by #12

Comments

@FabianSchmick
Copy link
Member

FabianSchmick commented Dec 20, 2018

Hi there,

first of all I wanted to say that this is an awesome bundle and we are using this successfully in some older projects. Thank you for sharing this.

For our current project we are using symfony 3.4, but it seems there are some compatibility conflicts with it. If I require the bundle it returns this console output:

$ composer require webfactory/legacy-integration-bundle

Using version ^1.4 for webfactory/legacy-integration-bundle
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Conclusion: remove symfony/symfony v3.4.20
    - Conclusion: don't install symfony/symfony v3.4.20
    - webfactory/legacy-integration-bundle 1.4.0 requires symfony/config ~2.2 -> satisfiable by symfony/config[v2.2.0, ......, v2.8.9].
    - webfactory/legacy-integration-bundle 1.4.1 requires symfony/config ~2.2 -> satisfiable by symfony/config[v2.2.0, ......, v2.8.9].
    - don't install symfony/config v2.4.0|don't install symfony/symfony v3.4.20
    ......
    - don't install symfony/config v2.2.9|don't install symfony/symfony v3.4.20
    - Installation request for symfony/symfony (locked at v3.4.20, required as 3.4.*) -> satisfiable by symfony/symfony[v3.4.20].
    - Installation request for webfactory/legacy-integration-bundle ^1.4 -> satisfiable by webfactory/legacy-integration-bundle[1.4.0, 1.4.1].

Installation failed, reverting ./composer.json to its original content.

Is there any chance you can publish a newer version with compatibility for newer symfony versions? Or am I doing something wrong and it should work installing?

@mpdude
Copy link
Member

mpdude commented Dec 20, 2018

No, you're right, the version constraints in composer.json are limited to Symfony 2.x.

I've created a branch with relaxed constraints. To be honest, I don't know if this code is going to work with Symfony 3 or 4. But you can give it a try and report back!

Just use "webfactory/legacy-integration-bundle": "dev-relax-version-constraint" in your composer.json file and run composer update.

@FabianSchmick
Copy link
Member Author

Thank you, I tested it and it seemes to be working.

@mpdude
Copy link
Member

mpdude commented Dec 21, 2018

I'll leave this open for some time, maybe others want to test it as well and report back.

Once we merge this I'll leave a short note here, so make sure to subscribe to this issue.

@mpdude
Copy link
Member

mpdude commented Dec 21, 2018

Just changed my mind and made a 1.5 release because we can still deliver fixes later on.

So, @FabianSchmick, replace dev-relax-version-constraint with ^1.5 in your composer.json file.

@FabianSchmick
Copy link
Member Author

Thanks for your reply. I will let you know if I find any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants