Skip to content
Permalink
Browse files

Breaking: Remove `chromium-finder` from `@hint/utils`

  • Loading branch information
molant committed Nov 21, 2019
1 parent 34bd5dc commit 8ed008ffe926edba18390bc12e909ac77799b2c8
@@ -12,6 +12,7 @@
"bundleSize": 660000,
"description": "webhint browser extension",
"devDependencies": {
"@hint/connector-puppeteer": "^2.4.0",
"@hint/hint-axe": "^4.2.0",
"@hint/hint-button-type": "^2.2.11",
"@hint/hint-compat-api": "^4.2.0",
@@ -4,7 +4,7 @@ import test from 'ava';

import { Category } from '@hint/utils-types';

import { getInstallationPath } from '@hint/utils';
import { getInstallationPath } from '@hint/connector-puppeteer/dist/src/lib/chromium-finder';
import { readFileAsync } from '@hint/utils-fs';
import { Server } from '@hint/utils-create-server';

@@ -2,7 +2,8 @@ import * as isCI from 'is-ci';
import { launch, Browser, Frame, Page, Target } from 'puppeteer-core';
import test from 'ava';

import { delay, getInstallationPath } from '@hint/utils';
import { getInstallationPath } from '@hint/connector-puppeteer/dist/src/lib/chromium-finder';
import { delay } from '@hint/utils';
import { Server } from '@hint/utils-create-server';

import { Events, Results } from '../src/shared/types';
@@ -61,19 +61,6 @@ hints inside the extended configurations.
* `isTextMediaType`: Check if a mime-type represents a text-based
resource.

### chromiumFinder

* `Browser`: An enum with the Chromium based browsers supported: Chrome,
Chromium, and Edge.
* `getInstallationPath`: Searchs for a valid Chromium browser from the ones
supported. The current priority list is:
* `Chrome Canary`, `Chrome`, `Chromium`, `Edge Canary`, `Edge Dev` (`Edge`
on `win32` and `darwin` platforms). A user can also pass the browser to use
(`Chrome`, `Chromium`, `Edge`) via the `options` parameter
(`options.browser`) or a `path` to the executable (`options.browserPath`) to
use (`getInstallationPath` will only verify it exists, not if it's actually
a valid target).

### logger

* `error`: Cover for console.error.

0 comments on commit 8ed008f

Please sign in to comment.
You can’t perform that action at this time.