Skip to content
Permalink
Browse files

Chore: Replace `Chrome` with `Puppeteer` in `ignoredConnectors`

  • Loading branch information...
molant committed May 3, 2019
1 parent 54431c8 commit d8041ab5d5aff7339cc37b283bd502549a49f987
@@ -19,9 +19,9 @@ const hintPath = getHintPath(__filename);

/*
* TODO: Remove `ignoredConnectors` part once headless
* Chrome on CI doesn't fail. :(
* Chromium on CI doesn't fail. :(
*/
const testConfigs = { ignoredConnectors: ['chrome'], serial: false };
const testConfigs = { ignoredConnectors: ['puppeteer'], serial: false };
const testConfigsSerial = Object.assign({}, testConfigs);

testConfigsSerial.serial = true;
@@ -25,7 +25,7 @@ const hintPath = getHintPath(__filename);
*/
const testConfigs = {
https: true,
ignoredConnectors: ['chrome'],
ignoredConnectors: ['puppeteer'],
serial: false
};

@@ -138,17 +138,17 @@ const noConfigTest: HintTest[] = [

testHint(hintPath, testThresholds, {
hintOptions: { apiKey: 'fakeApiName', apiSecret: 'fakeApiSecret', cloudName: 'fakeCloudName', threshold: 150 },
ignoredConnectors: ['chrome'],
ignoredConnectors: ['puppeteer'],
serial: true
});

testHint(hintPath, tests, {
hintOptions: { apiKey: 'fakeApiName', apiSecret: 'fakeApiSecret', cloudName: 'fakeCloudName' },
ignoredConnectors: ['chrome'],
ignoredConnectors: ['puppeteer'],
serial: true
});

testHint(hintPath, noConfigTest, {
ignoredConnectors: ['chrome'],
ignoredConnectors: ['puppeteer'],
serial: true
});
@@ -201,7 +201,7 @@ testHint(hintPath, defaultTests, {
* Issue: https://bugs.chromium.org/p/chromium/issues/detail?id=692090.
* TODO: Update the tests once the issue above is fixed.
*/
ignoredConnectors: ['chrome']
ignoredConnectors: ['puppeteer']
});

testHint(hintPath, newBrowserOnlyTests, {
@@ -210,15 +210,15 @@ testHint(hintPath, newBrowserOnlyTests, {
'last 2 versions'
],
https: true,
ignoredConnectors: ['chrome']
ignoredConnectors: ['puppeteer']
});

testHint(hintPath, olderBrowserOnlyTests, {
browserslist: [
'ie 6', 'ie 7'
],
https: true,
ignoredConnectors: ['chrome']
ignoredConnectors: ['puppeteer']
});

testHint(hintPath, oldAndNewBrowsersTest, {
@@ -227,5 +227,5 @@ testHint(hintPath, oldAndNewBrowsersTest, {
'last 2 versions'
],
https: true,
ignoredConnectors: ['chrome']
ignoredConnectors: ['chrompuppeteerium']
});
@@ -232,7 +232,7 @@ test(`If a hint has the metadata "ignoredConnectors" set up, we should ignore th

public static readonly meta: HintMetadata = {
id: 'disallowed-headers',
ignoredConnectors: ['chrome'],
ignoredConnectors: ['puppeteer'],
schema: [],
scope: HintScope.any
}
@@ -257,7 +257,7 @@ test(`If a hint has the metadata "ignoredConnectors" set up, we should ignore th

new Engine({
browserslist: [],
connector: { name: 'chrome' },
connector: { name: 'puppeteer' },
extends: [],
formatters: [],
hints: {

0 comments on commit d8041ab

Please sign in to comment.
You can’t perform that action at this time.