New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfills to add to jsdom connector #1223

Closed
molant opened this Issue Aug 8, 2018 · 4 comments

Comments

Projects
3 participants
@molant
Member

molant commented Aug 8, 2018

Making a list of polyfills or fallbacks we need to add to jsdom based on issues that have been opened:

I expect this list to grow. I'll be closing all the other issues and point to this one.

@antross

This comment has been minimized.

Member

antross commented Aug 22, 2018

Note jsdom should provide requestAnimationFrame if we set the right flags, though our ability to do so may be dependent on #163:

new JSDOM(``, { pretendToBeVisual: true })

See https://github.com/jsdom/jsdom#pretending-to-be-a-visual-browser

@molant

This comment has been minimized.

Member

molant commented Aug 22, 2018

Great, I didn't know about that option.
@sarvaje can you please add that option in your work for #163?

@molant

This comment has been minimized.

Member

molant commented Aug 22, 2018

Also we might want to do something like jsdom/jsdom#2342 for clientWidth and clientHeight.

@sarvaje

This comment has been minimized.

Member

sarvaje commented Sep 7, 2018

These and some others should be done in #1274

@molant molant added this to To do in October '18 🍁🍂 via automation Oct 1, 2018

@molant molant moved this from To do to In progress in October '18 🍁🍂 Oct 1, 2018

molant added a commit to molant/hint that referenced this issue Oct 1, 2018

Fix: Update `jsdom` to `v12.1.0`
* Update to latest `jsdom` version.
* Remove `@types/jsdom` to avoid TypeScript problems.
* Enable `includeNodeLocations` to jsdom.
* Add polyfills to increase compatibility.

- - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#163
Fix webhintio#1289
Fix webhintio#1223

molant added a commit to molant/hint that referenced this issue Oct 1, 2018

Fix: Update `jsdom` to `v12.1.0`
* Update to latest `jsdom` version.
* Remove `@types/jsdom` to avoid TypeScript problems.
* Enable `includeNodeLocations` to jsdom.
* Add polyfills to increase compatibility.

- - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#163
Fix webhintio#1289
Fix webhintio#1223

@molant molant referenced this issue Oct 1, 2018

Closed

Fix: Update `jsdom` to `v12.1.0` #1357

2 of 4 tasks complete

molant added a commit to molant/hint that referenced this issue Oct 1, 2018

Fix: Update `jsdom` to `v12.1.0`
* Update to latest `jsdom` version.
* Remove `@types/jsdom` to avoid TypeScript problems.
* Enable `includeNodeLocations` to jsdom.
* Add polyfills to increase compatibility.

- - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#163
Fix webhintio#1289
Fix webhintio#1223

molant added a commit to molant/hint that referenced this issue Oct 1, 2018

Fix: Update `jsdom` to `v12.1.0`
* Update to latest `jsdom` version.
* Remove `@types/jsdom` to avoid TypeScript problems.
* Enable `includeNodeLocations` to jsdom.
* Add polyfills to increase compatibility.

- - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#163
Fix webhintio#1289
Fix webhintio#1223

molant added a commit to molant/hint that referenced this issue Oct 1, 2018

Fix: Update `jsdom` to `v12.1.0`
* Update to latest `jsdom` version.
* Remove `@types/jsdom` to avoid TypeScript problems.
* Enable `includeNodeLocations` to jsdom.
* Add polyfills to increase compatibility.

- - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#163
Fix webhintio#1289
Fix webhintio#1223

molant added a commit to molant/hint that referenced this issue Oct 1, 2018

Fix: Update `jsdom` to `v12.1.0`
* Update to latest `jsdom` version.
* Remove `@types/jsdom` to avoid TypeScript problems.
* Enable `includeNodeLocations` to jsdom.
* Add polyfills to increase compatibility.

- - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#163
Fix webhintio#1289
Fix webhintio#1223

molant added a commit to molant/hint that referenced this issue Oct 2, 2018

Fix: Update `jsdom` to `v12.1.0`
* Update to latest `jsdom` version.
* Remove `@types/jsdom` to avoid TypeScript problems.
* Enable `includeNodeLocations` to jsdom.
* Add polyfills to increase compatibility.

- - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#163
Fix webhintio#1289
Fix webhintio#1223

antross added a commit to molant/hint that referenced this issue Oct 2, 2018

Fix: Update `jsdom` to `v12.1.0`
* Update to latest `jsdom` version.
* Remove `@types/jsdom` to avoid TypeScript problems.
* Enable `includeNodeLocations` to jsdom.
* Add polyfills to increase compatibility.

- - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#163
Fix webhintio#1289
Fix webhintio#1223

molant added a commit to molant/hint that referenced this issue Oct 2, 2018

Fix: Update `jsdom` to `v12.1.0`
* Update to latest `jsdom` version.
* Enable `includeNodeLocations` to jsdom.
* Improve `@types/jsdom` with ResourceLoader.
* Add polyfills to increase compatibility.

- - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#163
Fix webhintio#1289
Fix webhintio#1223

@alrra alrra closed this in f825d20 Oct 3, 2018

October '18 🍁🍂 automation moved this from In progress to Done Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment