New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using `web-recommended` configuration add `summary` formatter to the output. #1273

Closed
sarvaje opened this Issue Aug 27, 2018 · 8 comments

Comments

Projects
None yet
3 participants
@sarvaje
Member

sarvaje commented Aug 27, 2018

Please tell us about your:

Environment

  • hint version: 3.2.3
  • Node.js version: 8.11.3
  • npm version: 6.2.0

webhint configuration

webhint’s configuration
{
    "formatters": ["summary"],
    "extends": ["web-recommended"]
}

Output

image

@molant

This comment has been minimized.

Member

molant commented Aug 28, 2018

So we need to look for unique items in the formatters property. We probably should the same in parsers.

@molant molant self-assigned this Aug 28, 2018

molant added a commit to molant/hint that referenced this issue Aug 28, 2018

Fix: Remove duplicate values when extending config
Use only unique values for `formatters` and `parsers` when calculating
the final configuration of an `extends`.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#1273
@molant

This comment has been minimized.

Member

molant commented Aug 28, 2018

There's a PR for this now (#1276)

@alrra alrra closed this in ea3ae22 Aug 28, 2018

@sarvaje sarvaje reopened this Aug 28, 2018

@sarvaje

This comment has been minimized.

Member

sarvaje commented Aug 28, 2018

Now, if you choose the formatter summary it is printed just once, but if I choose another formatter, the summary formatter is printed anyway.

try with this config:

{
    "formatters": ["stylish"],
    "extends": ["web-recommended"]
}

you will get the stylish result and then the summary result.

@molant

This comment has been minimized.

Member

molant commented Aug 28, 2018

so formatters and parsers should be different? When do we combine vs replacing?

@sarvaje

This comment has been minimized.

Member

sarvaje commented Aug 28, 2018

IMO, formatters should be replaced and parsers combined

@sarvaje

This comment has been minimized.

Member

sarvaje commented Sep 4, 2018

@webhintio/contributors what do you think? should formatters be replaced and parsers combined`? or everything combined?

@molant

This comment has been minimized.

Member

molant commented Sep 4, 2018

I'm ok with formatters being replaced. We should document that in "extending configurations" though.

@molant

This comment has been minimized.

Member

molant commented Sep 4, 2018

Also be aware that there's #1280 that seemed to happen when this was introduced.

@sarvaje sarvaje assigned sarvaje and unassigned molant Sep 5, 2018

sarvaje added a commit to sarvaje/hint that referenced this issue Sep 5, 2018

@sarvaje sarvaje referenced this issue Sep 5, 2018

Closed

Fix: Summary formatter always used #1290

4 of 4 tasks complete

@alrra alrra closed this in 03555d8 Sep 5, 2018

@alrra alrra reopened this Sep 5, 2018

sarvaje added a commit to sarvaje/hint that referenced this issue Sep 5, 2018

@alrra alrra closed this in 43a06a9 Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment