New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect hops can fail in some cases #1403

Closed
sarvaje opened this Issue Oct 15, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@sarvaje
Member

sarvaje commented Oct 15, 2018

Imagine this scenario:
http://a.com => https://a.com
https://a.com => https://a.com/token
https://a.com/token => https://a.com

where => is a redirect.

In the current RedirectManager, the last redirect overwrite the first one, because the "index" is the same https://a.com

@sarvaje

This comment has been minimized.

Member

sarvaje commented Oct 15, 2018

I think this should be done as part of #1398

@molant

This comment has been minimized.

Member

molant commented Oct 15, 2018

I think this should be done as part of #1398

This should be solved with the current refactor I'm working on 😊

molant added a commit to molant/hint that referenced this issue Oct 17, 2018

Fix: Refactor debugging protocol
Refactor how the interaction with the debugging protocol is handled
while fixing some of the most recent issues found.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#1398
Fix webhintio#1395
Fix webhintio#1403
Fix webhintio/rfcs#44

molant added a commit to molant/hint that referenced this issue Oct 17, 2018

Fix: Refactor debugging protocol
Refactor how the interaction with the debugging protocol is handled
while fixing some of the most recent issues found.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#1398
Fix webhintio#1395
Fix webhintio#1403
Fix webhintio/rfcs#44

molant added a commit to molant/hint that referenced this issue Oct 17, 2018

Fix: Refactor debugging protocol
Refactor how the interaction with the debugging protocol is handled
while fixing some of the most recent issues found.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#1398
Fix webhintio#1395
Fix webhintio#1403
Fix webhintio/rfcs#44

molant added a commit to molant/hint that referenced this issue Oct 18, 2018

Fix: Refactor debugging protocol
Refactor how the interaction with the debugging protocol is handled
while fixing some of the most recent issues found.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#1398
Fix webhintio#1395
Fix webhintio#1403
Fix webhintio/rfcs#44

molant added a commit to molant/hint that referenced this issue Oct 18, 2018

Fix: Refactor debugging protocol
Refactor how the interaction with the debugging protocol is handled
while fixing some of the most recent issues found.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#1398
Fix webhintio#1395
Fix webhintio#1403
Fix webhintio/rfcs#44

@alrra alrra closed this in 5d8a804 Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment