New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsdom to new API #163

Closed
molant opened this Issue Apr 27, 2017 · 4 comments

Comments

Projects
2 participants
@molant
Member

molant commented Apr 27, 2017

jsdom's new version has a new and shiny API 馃帀

PR #144 updates to v10 but it uses the old API so #161 gets unblocked once it is merged.

We should update to the new way of doings things asap (although there seems to be a few features that are not yet supported.

Sub-tasks:

  • Websites with relative links will not load correctly #96
  • Create infrastructure to inject JS #129
  • Add canvas or canvas-prebuilt as a peer dependency to download the images #241

@molant molant added this to TODO in v1 Apr 27, 2017

@molant molant moved this from TODO to Committed in v1 Apr 27, 2017

@molant molant self-assigned this Apr 27, 2017

@molant molant referenced this issue Apr 27, 2017

Closed

CDP improvements #144

alrra added a commit that referenced this issue Apr 27, 2017

Update `jsdom` to `v10`, but for now, use old API
From https://github.com/tmpvar/jsdom/blob/b2bfc3d056a5af1f8305720abd70cb1a218a9509/lib/old-api.md:

 " The old jsdom API, from before v10, is hard to use and understand,
   and has bad defaults. But for now, it still has more features
   than the new API introduced in v10. As such, it is still supported,
   until we can port over all important features (notably custom
   resource loading) to the new API. "

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Ref #163
Close #144

alrra added a commit that referenced this issue Apr 27, 2017

Update `jsdom` to `v10`, but for now, use old API
From https://github.com/tmpvar/jsdom/blob/b2bfc3d056a5af1f8305720abd70cb1a218a9509/lib/old-api.md:

 " The old jsdom API, from before v10, is hard to use and understand,
   and has bad defaults. But for now, it still has more features
   than the new API introduced in v10. As such, it is still supported,
   until we can port over all important features (notably custom
   resource loading) to the new API. "

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Ref #163
Close #144
@molant

This comment has been minimized.

Member

molant commented Apr 27, 2017

I have a branch with the current work in progress.
Unfortunately we cannot migrate to v10 just yet because resourceLoader is missing so I'll submit separate PRs for #96 and #129 for the old api.

@molant molant moved this from Committed to TODO in v1 Apr 27, 2017

@molant molant changed the title from Update jsdom to v10 to Update jsdom to v11 May 22, 2017

@molant

This comment has been minimized.

Member

molant commented May 22, 2017

@molant molant changed the title from Update jsdom to v11 to Update jsdom to new API Oct 24, 2017

@molant

This comment has been minimized.

Member

molant commented Nov 8, 2017

We still need resourceLoader to migrate to the new API. We should evaluate adding that feature so we can migrate to the new API. The new API seems to be more reliable as we can see in #521 and #589 so this might be worth trying to improve our success rate in the online scanner.

@alrra

This comment has been minimized.

Member

alrra commented Aug 19, 2018

resourceLoader

New resource loader API is now available in v12, see: https://github.com/jsdom/jsdom/blob/master/Changelog.md#1200 馃帀

Great work @sarvaje!

@antross antross referenced this issue Aug 22, 2018

Closed

Polyfills to add to jsdom connector #1223

0 of 3 tasks complete

molant added a commit to molant/hint that referenced this issue Oct 1, 2018

Fix: Update `jsdom` to `v12.1.0`
* Update to latest `jsdom` version.
* Remove `@types/jsdom` to avoid TypeScript problems.
* Enable `includeNodeLocations` to jsdom.
* Add polyfills to increase compatibility.

- - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#163
Fix webhintio#1289
Fix webhintio#1223

molant added a commit to molant/hint that referenced this issue Oct 1, 2018

Fix: Update `jsdom` to `v12.1.0`
* Update to latest `jsdom` version.
* Remove `@types/jsdom` to avoid TypeScript problems.
* Enable `includeNodeLocations` to jsdom.
* Add polyfills to increase compatibility.

- - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#163
Fix webhintio#1289
Fix webhintio#1223

@molant molant referenced this issue Oct 1, 2018

Closed

Fix: Update `jsdom` to `v12.1.0` #1357

2 of 4 tasks complete

molant added a commit to molant/hint that referenced this issue Oct 1, 2018

Fix: Update `jsdom` to `v12.1.0`
* Update to latest `jsdom` version.
* Remove `@types/jsdom` to avoid TypeScript problems.
* Enable `includeNodeLocations` to jsdom.
* Add polyfills to increase compatibility.

- - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#163
Fix webhintio#1289
Fix webhintio#1223

molant added a commit to molant/hint that referenced this issue Oct 1, 2018

Fix: Update `jsdom` to `v12.1.0`
* Update to latest `jsdom` version.
* Remove `@types/jsdom` to avoid TypeScript problems.
* Enable `includeNodeLocations` to jsdom.
* Add polyfills to increase compatibility.

- - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#163
Fix webhintio#1289
Fix webhintio#1223

molant added a commit to molant/hint that referenced this issue Oct 1, 2018

Fix: Update `jsdom` to `v12.1.0`
* Update to latest `jsdom` version.
* Remove `@types/jsdom` to avoid TypeScript problems.
* Enable `includeNodeLocations` to jsdom.
* Add polyfills to increase compatibility.

- - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#163
Fix webhintio#1289
Fix webhintio#1223

molant added a commit to molant/hint that referenced this issue Oct 1, 2018

Fix: Update `jsdom` to `v12.1.0`
* Update to latest `jsdom` version.
* Remove `@types/jsdom` to avoid TypeScript problems.
* Enable `includeNodeLocations` to jsdom.
* Add polyfills to increase compatibility.

- - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#163
Fix webhintio#1289
Fix webhintio#1223

molant added a commit to molant/hint that referenced this issue Oct 2, 2018

Fix: Update `jsdom` to `v12.1.0`
* Update to latest `jsdom` version.
* Remove `@types/jsdom` to avoid TypeScript problems.
* Enable `includeNodeLocations` to jsdom.
* Add polyfills to increase compatibility.

- - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#163
Fix webhintio#1289
Fix webhintio#1223

antross added a commit to molant/hint that referenced this issue Oct 2, 2018

Fix: Update `jsdom` to `v12.1.0`
* Update to latest `jsdom` version.
* Remove `@types/jsdom` to avoid TypeScript problems.
* Enable `includeNodeLocations` to jsdom.
* Add polyfills to increase compatibility.

- - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#163
Fix webhintio#1289
Fix webhintio#1223

molant added a commit to molant/hint that referenced this issue Oct 2, 2018

Fix: Update `jsdom` to `v12.1.0`
* Update to latest `jsdom` version.
* Enable `includeNodeLocations` to jsdom.
* Improve `@types/jsdom` with ResourceLoader.
* Add polyfills to increase compatibility.

- - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#163
Fix webhintio#1289
Fix webhintio#1223

@alrra alrra closed this in f825d20 Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment