Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hint-sri to work with connector-local and validate external resources [3] #1632

Closed
antross opened this issue Sep 12, 2018 · 0 comments · Fixed by #1826
Closed

Update hint-sri to work with connector-local and validate external resources [3] #1632

antross opened this issue Sep 12, 2018 · 0 comments · Fixed by #1826

Comments

@antross
Copy link
Member

antross commented Sep 12, 2018

Currently this hint relies on external resources being fetched, but connector-local intentionally doesn't fetch external resources as it works with static files.

I propose we update this hint to fetch external resources (e.g. from a CDN) itself when running locally. Local files would be difficult to validate as they're potentially changing frequently... perhaps we could do something special for items coming from package.json dependencies. This should likely also include some caching to avoid an abundance requests to external resources from repeated runs during development.

@molant molant transferred this issue from webhintio/rfcs Jan 8, 2019
@antross antross added this to the 1902-1 milestone Jan 28, 2019
sarvaje added a commit to sarvaje/hint that referenced this issue Feb 4, 2019
sarvaje added a commit to sarvaje/hint that referenced this issue Feb 4, 2019
sarvaje added a commit to sarvaje/hint that referenced this issue Feb 4, 2019
@sarvaje sarvaje changed the title Update hint-sri to work with connector-local and validate external resources Update hint-sri to work with connector-local and validate external resources [2] Feb 4, 2019
molant pushed a commit that referenced this issue Feb 7, 2019
@sarvaje sarvaje changed the title Update hint-sri to work with connector-local and validate external resources [2] Update hint-sri to work with connector-local and validate external resources [3] Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants