Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Run test web server(s) in a separate thread #1694

Closed
molant opened this issue Jan 16, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@molant
Copy link
Member

commented Jan 16, 2019

馃殌 Feature request

Description

Right now the web server created by hintRunner runs in the same process.
Spawn the web server into its own process. Right now the web server and the tests run in the same process and I think that some of the timeouts we are getting are because of that.

Are you willing to work on this? 馃槒

What scenarios will this solve?

This should hopefully make the tests more reliable. I have a feeling that because everything is running in the same thread sometimes we get timeouts when we shouldn't or that we are serving old content.
This will probably have a perf impact because we will be spawning quite a few new processes so we need to be careful how we do this. An option could be to use one process per testing file instead of per test.

@molant molant self-assigned this Jan 18, 2019

@molant molant added this to the 1901-2 milestone Jan 18, 2019

molant added a commit to molant/hint that referenced this issue Jan 24, 2019

@molant molant referenced this issue Jan 24, 2019

Merged

Breaking: Spawn webserver in separate process #1758

6 of 6 tasks complete

molant added a commit to molant/hint that referenced this issue Jan 24, 2019

molant added a commit to molant/hint that referenced this issue Jan 25, 2019

molant added a commit to molant/hint that referenced this issue Jan 25, 2019

molant added a commit to molant/hint that referenced this issue Jan 25, 2019

molant added a commit to molant/hint that referenced this issue Jan 25, 2019

molant added a commit to molant/hint that referenced this issue Jan 25, 2019

molant added a commit to molant/hint that referenced this issue Jan 25, 2019

molant added a commit to molant/hint that referenced this issue Jan 25, 2019

@molant molant closed this in #1758 Jan 28, 2019

molant added a commit that referenced this issue Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.