New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hint-typescript-config] Report inherited errors at `extends` location [1.5] #1717

Closed
antross opened this Issue Jan 18, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@antross
Copy link
Member

antross commented Jan 18, 2019

馃殌 Feature request

Description

What do you want to be added?

Currently errors in a tsconfig.json file which originate in a parent tsconfig.json file imported via extends are reported at position 0, 0. This is confusing as it's not clear where the error is originating from. I propose reporting inherited errors at the extends location instead to more clearly communicate where they're coming from (the imported file).

Are you willing to work on this?

Yes.

What scenarios will this solve?

Why do you want/need this?

To help developers find where an error originates so it can be fixed.

@antross

This comment has been minimized.

Copy link
Member Author

antross commented Jan 28, 2019

This likely also affects hint-babel-config as it has a similar extends mechanism.

@antross antross added this to the 1902-1 milestone Jan 28, 2019

@molant molant self-assigned this Jan 31, 2019

molant added a commit to molant/hint that referenced this issue Jan 31, 2019

molant added a commit to molant/hint that referenced this issue Feb 1, 2019

molant added a commit to molant/hint that referenced this issue Feb 1, 2019

molant added a commit to molant/hint that referenced this issue Feb 1, 2019

molant added a commit to molant/hint that referenced this issue Feb 1, 2019

molant added a commit to molant/hint that referenced this issue Feb 1, 2019

@molant molant closed this in #1808 Feb 5, 2019

molant added a commit that referenced this issue Feb 5, 2019

@molant molant changed the title [hint-typescript-config] Report inherited errors at `extends` location [hint-typescript-config] Report inherited errors at `extends` location [1.5] Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment