Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Not all file names follow the same convention #1748

Closed
molant opened this Issue Jan 23, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@molant
Copy link
Member

molant commented Jan 23, 2019

馃悰 Bug report

Description

All files should be lower case and dash separated. There are some that don't follow this convention such as fetchContent.ts in connector-chrome.

@karansapolia

This comment has been minimized.

Copy link
Contributor

karansapolia commented Feb 6, 2019

There are more files in packages/hint/src/lib/enums , namely hintscope.ts, errorstatus.ts, resourcetype.ts which do not follow the convention. Possibly there are more. If renaming the files does not cause anything to break, I would be more than happy to do the legwork here :-). Should I go ahead with it?

@molant

This comment has been minimized.

Copy link
Member Author

molant commented Feb 6, 2019

Renaming shouldn't break anything as long as the references are updated in the code. Please go ahead and thank you!

karansapolia added a commit to karansapolia/hint that referenced this issue Feb 7, 2019

Fix: Refactor for file name convention
Rename files which do not follow naming convention of
lower case dash seperated file names. Update all references
changed file names.

 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#1748

@karansapolia karansapolia referenced this issue Feb 7, 2019

Merged

Fix: Refactor for file name convention #1861

3 of 3 tasks complete

molant added a commit to karansapolia/hint that referenced this issue Feb 11, 2019

Fix: Refactor for file name convention
Rename files which do not follow naming convention of
lower case dash seperated file names. Update all references
changed file names.

 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#1748

@molant molant referenced this issue Feb 11, 2019

Closed

Fix: Refactor for file name convention #1875

2 of 2 tasks complete

@molant molant closed this in #1861 Feb 11, 2019

molant added a commit that referenced this issue Feb 11, 2019

Fix: Refactor for file name convention (#1861)
Rename files which do not follow naming convention of lower case
dash seperated file names. Update all references changed file
names.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix #1748
Close #1861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.