Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] create-hint `package.json#main` doesn't point to the right file [0.2] #1916

Closed
molant opened this issue Feb 14, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@molant
Copy link
Member

commented Feb 14, 2019

馃悰 Bug report

Description

When creating a single hint using create-hint the generated package.json main property points to index.js instead of hint.js

Need to check what happens when creating a multi-hint though.

@molant molant added the type:bug label Feb 14, 2019

@molant

This comment has been minimized.

Copy link
Member Author

commented Feb 19, 2019

I think the problem is that we are creating an index.ts file that is kind of verbose and doesn't follow what we are doing in core. The output of single hint and multi hint should have the same output as the files we have in the project.

@molant molant added this to the 1904-1 milestone Mar 22, 2019

@molant molant self-assigned this Apr 3, 2019

molant added a commit to molant/hint that referenced this issue Apr 3, 2019

Fix: Point to right entry point
If the user creates a new individual hint, `package.json` will point to
`dist/src/hint.js` instead of `dist/src/index.js` and will no longer
create an `index.js`. This is consistent with the format of the other
hints.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#1916

@molant molant referenced this issue Apr 3, 2019

Merged

Fix: Point to right entry point #2171

3 of 3 tasks complete

@molant molant changed the title [Bug] create-hint `package.json#main` doesn't point to the right file [Bug] create-hint `package.json#main` doesn't point to the right file [0.2] Apr 3, 2019

@molant molant closed this in #2171 Apr 3, 2019

molant added a commit that referenced this issue Apr 3, 2019

Fix: Point to right entry point
If the user creates a new individual hint, `package.json` will point to
`dist/src/hint.js` instead of `dist/src/index.js` and will no longer
create an `index.js`. This is consistent with the format of the other
hints.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix #1916
Close #2171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.