Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Expand all close all buttons are cut. #1985

Open
sarvaje opened this Issue Feb 27, 2019 · 9 comments

Comments

Projects
None yet
3 participants
@sarvaje
Copy link
Member

commented Feb 27, 2019

Steps to reproduce:

  1. Go to https://webhint.io/scanner/
  2. Scan an url

Expected:
Expand/collapse all button should looks ok.

Actual:
image
image

@molant

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

Guess this is for @ststimac?

@sarvaje

This comment has been minimized.

Copy link
Member Author

commented Feb 27, 2019

Yes, or for me if @ststimac doesn't have time.

@ststimac

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

I've got time. :)

@ststimac

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

This is one of the tasks under my "scan results clean up" already.

@sarvaje

This comment has been minimized.

Copy link
Member Author

commented Feb 28, 2019

Ok!

ststimac added a commit to ststimac/hint that referenced this issue Feb 28, 2019

Fix: Button cut off and misc a11y fix
Adjusted code to fix the expand all, close all button being cut off.
Removed unnecessary role=main on the Hints container.

Fix webhintio#1985

@ststimac ststimac referenced this issue Feb 28, 2019

Merged

Fix button cutoff and misc a11y issue #1989

4 of 4 tasks complete

@molant molant closed this in #1989 Mar 1, 2019

molant added a commit that referenced this issue Mar 1, 2019

Fix: Button cutoff and misc a11y issues
* Adjusted code to fix the expand all, close all button being cut off.
* Removed unnecessary role=main on the Hints container.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix #1985
Close #1989
@ststimac

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

Hmmm, so this is still showing up in the formatter as cut off.

@ststimac ststimac reopened this Mar 15, 2019

@molant

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

In the website or using the CLI? We haven't released a new version of the site in a few days because of an issue with SRI and I'm not sure if the change got in the latest published version if you are using the CLI.

@ststimac

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

I've cleared my cache just to make sure, but the old code and style is still coming through. Need to look into this.

@ststimac

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

Still an issue, but only in one state:

Screen Shot 2019-03-15 at 9 20 42 AM

Background position is only being applied to the closed class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.