Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Audit pinned versions of packages #2025

Closed
molant opened this issue Mar 6, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@molant
Copy link
Member

commented Mar 6, 2019

Packages that need to be pinned:

Package version reason
proxyquire v2.0.0 v2.1.0 has a problem with one of it dependencies that breaks our current tests
exceljs v1.7.0 v1.9.0 has a problem in it types definition (exceljs/exceljs#773)
angular, moment, jquery in hint-no-vulnerable-javascript-libraries N/A testing
mine-db v1.35.0 error when deciding the mimetype of .ico files

Original issue:

There are some packages with pinned version such as utils-tests-helpers with @typescript-eslint/parser": "1.4.2"

We should review all our pinned dependencies and make sure they should be or not.

@molant molant added the type:bug label Mar 6, 2019

@sarvaje sarvaje self-assigned this Apr 12, 2019

@molant molant added this to the 1904-1 milestone Apr 12, 2019

sarvaje added a commit to sarvaje/hint that referenced this issue Apr 13, 2019

@sarvaje sarvaje referenced this issue Apr 13, 2019

Merged

Fix: Review pinned version of packages #2234

2 of 4 tasks complete

@molant molant pinned this issue Apr 13, 2019

@molant molant closed this in #2234 Apr 14, 2019

molant added a commit that referenced this issue Apr 14, 2019

@molant molant unpinned this issue May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.