Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Change how `boxen` is imported and remove `@types/boxen` #2036

Closed
molant opened this issue Mar 7, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@molant
Copy link
Member

commented Mar 7, 2019

boxen has now types included OOB. We should remove the @types/boxen from dependencies and use import boxen from 'boxen' instead of require('boxen').

@molant molant added the type:bug label Mar 7, 2019

@molant molant referenced this issue Mar 7, 2019

Merged

Traverse #1943

4 of 4 tasks complete

karansapolia added a commit to karansapolia/hint that referenced this issue Mar 14, 2019

Fix: Change 'boxen' import and remove '@types/boxen'
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#2036

karansapolia added a commit to karansapolia/hint that referenced this issue Mar 14, 2019

Fix: Change 'boxen' import and remove '@types/boxen'
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#2036

@molant molant closed this in #2063 Mar 15, 2019

molant added a commit that referenced this issue Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.