Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan results page: JS issue w/mobile menu [0.3] #2053

Closed
ststimac opened this issue Mar 6, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@ststimac
Copy link
Member

commented Mar 6, 2019

When a user has the categories expanded like this:
screen shot 2019-03-06 at 11 22 41 am

And is using the keyboard to tab through the the categories, if they hit "enter" to tab into a section, the categories menu is not closing when enter is being pressed. This is only happening via the keyboard, if someone is using a mouse to click the categories, a click event is happening. So we need an event for focusing and hitting enter that then closes the category menu.

Related to #640 but opening a separate issue to track as the other tasks under that issue are complete.

@sarvaje

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

This issue is part of the formatter, so I'm moving this issue to the hint repo.

@sarvaje sarvaje transferred this issue from webhintio/webhint.io Mar 12, 2019

sarvaje added a commit to sarvaje/hint that referenced this issue Mar 12, 2019

Fix: Accessibility issue in mobile menu.
Fix webhintio#2053

This commit also fix an issue when you refresh the
website after a category was clicked.

@sarvaje sarvaje added this to the 1903-2 milestone Mar 12, 2019

@sarvaje sarvaje changed the title Scan results page: JS issue w/mobile menu Scan results page: JS issue w/mobile menu [0.3] Mar 12, 2019

@sarvaje sarvaje referenced this issue Mar 12, 2019

Merged

Fix: Accessibility issue in mobile menu. #2054

2 of 4 tasks complete

@molant molant closed this in #2054 Mar 13, 2019

molant added a commit that referenced this issue Mar 13, 2019

Fix: Accessibility issue in mobile menu
Fix also an issue refreshing the site after a category is clicked.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix #2053
Close #2054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.