Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DOM utils inside hint to `@hint/utils` #2192

Closed
molant opened this issue Apr 9, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@molant
Copy link
Member

commented Apr 9, 2019

These should be able to be moved through a combination of moving any types they need to @hint/utils as well. The few exceptions are:

  1. Use of HTMLElement in content-type
    • Replace with a minimal local interface
  2. Use of Engine in traverse
    • Replace with EventEmitter2

Another thing to do is to re-export the types from hint.
Also classes like HTMLDocument might be moved as well.

@molant molant added the area:api label Apr 9, 2019

@antross

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

These should be able to be moved through a combination of moving any types they need to @hint/utils as well. The few exceptions are:

  1. Use of HTMLElement in content-type
    • Replace with a minimal local interface
  2. Use of Engine in traverse
    • Replace with EventEmitter2

@sarvaje sarvaje self-assigned this Apr 11, 2019

sarvaje added a commit to sarvaje/hint that referenced this issue Apr 11, 2019

@molant molant added this to the 1904-1 milestone Apr 12, 2019

@molant molant closed this in #2218 Apr 12, 2019

molant added a commit that referenced this issue Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.