Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update `configuration-pwas` with `manifest-icons` #2352

Closed
molant opened this issue May 1, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@molant
Copy link
Member

commented May 1, 2019

Now that manifest-icons is merged, we should update the configuration-pwa to have it.

@antross thoughts?

@shivangg want to take care of that?

@shivangg

This comment has been minimized.

Copy link
Member

commented May 1, 2019

@molant yeah, absolutely.

@antross

This comment has been minimized.

Copy link
Member

commented May 1, 2019

Yep, let's do this. 👍

@shivangg

This comment has been minimized.

Copy link
Member

commented May 2, 2019

@molant How will manifest-icons be installed unless it is published to NPM.
On using the configuration-progressive-web-apps, this would try to install the package @hint/hint-manifest-icons.

@shivangg shivangg referenced this issue May 2, 2019

Merged

Update: Add manifest-icons to config-pwa #2357

4 of 4 tasks complete
@molant

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

@molant molant closed this in #2357 May 7, 2019

molant added a commit that referenced this issue May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.