Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `browser` option for `connector-puppeteer` case-insensitive #3058

Closed
antross opened this issue Oct 1, 2019 · 5 comments · Fixed by #3380
Closed

Make `browser` option for `connector-puppeteer` case-insensitive #3058

antross opened this issue Oct 1, 2019 · 5 comments · Fixed by #3380

Comments

@antross
Copy link
Member

@antross antross commented Oct 1, 2019

Currently connector-puppeteer only accepts capitalized browser names: Chrome, Chromium, Edge.
It should also support the lower case versions.

The work that should happen is:


Original comment:

@antross on top of merging thins we should probably open an issue to make that parameter case insensitive. What do you think?

Originally posted by @molant in #3053 (comment)

@GabiOC

This comment has been minimized.

Copy link

@GabiOC GabiOC commented Oct 2, 2019

Hi @antross , I'd be happy to pick this one up!

@molant

This comment has been minimized.

Copy link
Member

@molant molant commented Oct 2, 2019

Go for it @GabiOC !

If you have any questions during the process please let us know.

@fs1337

This comment has been minimized.

Copy link

@fs1337 fs1337 commented Oct 18, 2019

@GabiOC I will pick it up if you are not working on it.

@GabiOC

This comment has been minimized.

Copy link

@GabiOC GabiOC commented Oct 19, 2019

Hi @fs1337 , yes, go for it! Apologies, I wasn't able to find the time to work on this.

@molant molant assigned sarvaje and molant and unassigned sarvaje Nov 21, 2019
molant added a commit to molant/hint that referenced this issue Nov 21, 2019
Additionally improve the exception message to know exactly what values
were used.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#3058
@molant molant mentioned this issue Nov 21, 2019
2 of 2 tasks complete
@molant molant closed this in #3380 Nov 22, 2019
molant added a commit that referenced this issue Nov 22, 2019
Additionally improve the exception message to know exactly what values
were used.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix #3058
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.