Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide `configuration-all` from create packages and website #3097

Closed
orokanasaru opened this issue Oct 8, 2019 · 2 comments · Fixed by #3367
Closed

Hide `configuration-all` from create packages and website #3097

orokanasaru opened this issue Oct 8, 2019 · 2 comments · Fixed by #3367
Assignees
Milestone

Comments

@orokanasaru
Copy link

@orokanasaru orokanasaru commented Oct 8, 2019

Using "extends": ["development", "accessibility", "web-recommended", "progressive-web-apps"], works, but "extends": ["all"] gives the error below.

npm rebuild on different versions of node gives different versions for compiled against, but none are 69. The version required looks to be a custom electron version, but I was unable to get it to build with electron-rebuild. The change above seems like a valid workaround, but it's non-obvious, and likely to be confusing to other users.

Environment

  • hint version: 5.3.1

  • Node.js version: 10.11.0/10.15.0/11.15.0/12.6.0

  • npm version: 6.9.0

  • VSCode
    Version: 1.38.1 (system setup)
    Commit: b37e54c98e1a74ba89e03073e5a3761284e3ffb0
    Date: 2019-09-11T13:35:15.005Z
    Electron: 4.2.10
    Chrome: 69.0.3497.128
    Node.js: 10.11.0
    V8: 6.9.427.31-electron.0
    OS: Windows_NT x64 10.0.18362

webhint configuration

webhint’s configuration
{
  "extends": ["all"],
  "hints": {
    "sri": ["warning", { "baseline": "sha256" }],
    "typescript-config/import-helpers": "off",
    "typescript-config/no-comments": "off"
  }

Output

Please include the raw output generated by webhint, or if possible,
the raw output from running webhint in debug mode: hint --debug <URL>.

webhint’s raw output
Found hint at \web\node_modules\hint\dist\src\lib\index.js
{ ResourceError: The module '\\?\node_modules\iltorb\build\bindings\iltorb.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 72. This version of Node.js requires
NODE_MODULE_VERSION 69. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or `npm install`).
@molant

This comment has been minimized.

Copy link
Member

@molant molant commented Oct 8, 2019

Hi @orokanasaru,

configuration-all isn't supposed to be used by anyone. We created it so we could pull all the documentation automatically in the website in one easy step. How did you ended up using it? From the docs in the website? npm create hintrc? Something else? Maybe we should filter that one out.

Also you can just have "extends": ["development", "web-recommended"] should be enough (development extends from progressive-web-apps and accessibility and web-recommended extends from accessibility)

That said, your issue is totally valid. We've seen similar issues in the past where the binary was installed in one platform for a particular node version (e.g.: WSL on Windows with node 12) and VS Code using a different internal version (node 10 on Windows).
For this case, maybe all is pulling a hint that isn't ready to be run from local and we forgot about it (and thus is trying to load iltorb)?

The current plan we have is to migrate to the built-in brotli implementation (#1604). This should fix at least these error.

I'm going to leave this one open so we can test once #1604 is shipped if all still fails to load on vs code and also to decide if we should filter out all from different places.

Thanks @orokanasaru

@orokanasaru

This comment has been minimized.

Copy link
Author

@orokanasaru orokanasaru commented Oct 8, 2019

I learned about all through npm create hintrc, though it's also documented on the site

@molant molant changed the title Can't extend 'all' in VS Code extension Hide `configuration-all` from create packages and website Nov 11, 2019
@molant molant mentioned this issue Nov 11, 2019
@molant molant added this to the 1911-2 milestone Nov 18, 2019
@molant molant self-assigned this Nov 18, 2019
molant added a commit to molant/hint that referenced this issue Nov 18, 2019
This configuration is only for internal consumption to get easy access
to all the documentation and should never be used by a user as it can
cause problems when extending from it.

This PR filters it when running `npm init hintrc` and verifies the
`.hintrc` doesn't `extends` from it.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#3097
@molant molant mentioned this issue Nov 18, 2019
3 of 3 tasks complete
molant added a commit to webhintio/webhint.io that referenced this issue Nov 18, 2019
@molant molant closed this in #3367 Nov 19, 2019
molant added a commit that referenced this issue Nov 19, 2019
This configuration is only for internal consumption to get easy access
to all the documentation and should never be used by a user as it can
cause problems when extending from it.

This PR filters it when running `npm init hintrc` and verifies the
`.hintrc` doesn't `extends` from it.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix #3097
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.