Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Color contrast with errors #3365

Closed
molant opened this issue Nov 18, 2019 · 2 comments · Fixed by #3384
Closed

[Bug] Color contrast with errors #3365

molant opened this issue Nov 18, 2019 · 2 comments · Fixed by #3384
Assignees
Milestone

Comments

@molant
Copy link
Member

@molant molant commented Nov 18, 2019

Report received via email:

If you write "Hint:1" in a small white font on this red (#D83B01) the
contrast is not sufficient enough.
A much darker red would be better.

@ststimac I don't think we've updated the colors with the latest changes, right? What red do you want to use to fix this?

@sarvaje FYI as this will probably something you have to integrate.

@sarvaje

This comment has been minimized.

Copy link
Member

@sarvaje sarvaje commented Nov 21, 2019

Now "Hint:1" is not in the extension, but we have
image

@ststimac

This comment has been minimized.

Copy link
Member

@ststimac ststimac commented Nov 21, 2019

The current color contrast is 4:61 which is passing, but we can use #C02E00, that will bump color contrast up to 5:78

sarvaje added a commit to sarvaje/hint that referenced this issue Nov 22, 2019
@sarvaje sarvaje mentioned this issue Nov 22, 2019
2 of 4 tasks complete
@molant molant closed this in #3384 Nov 22, 2019
molant added a commit that referenced this issue Nov 22, 2019
Fix #3365
Close #3384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.