Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] VS Code extension fails if the version of webhint is too old. #3386

Closed
sarvaje opened this issue Nov 22, 2019 · 0 comments
Closed

[Bug] VS Code extension fails if the version of webhint is too old. #3386

sarvaje opened this issue Nov 22, 2019 · 0 comments
Labels

Comments

@sarvaje
Copy link
Member

@sarvaje sarvaje commented Nov 22, 2019

The last version of VS Code extension fails if I have installed locally webhint v4.5.0

Found hint at /home/sarvaje/github/test/node_modules/hint/dist/src/lib/engine.js
(node:1577) UnhandledPromiseRejectionWarning: TypeError: e.getUserConfig is not a function
    at Object.t.getUserConfig (/home/sarvaje/.vscode-server/extensions/webhint.vscode-webhint-1.4.1/dist/bundle/server.js:13:6447)
    at t.Analyzer.initWebhint (/home/sarvaje/.vscode-server/extensions/webhint.vscode-webhint-1.4.1/dist/bundle/server.js:13:5531)
    at processTicksAndRejections (internal/process/task_queues.js:89:5)
    at async t.Analyzer.validateTextDocument (/home/sarvaje/.vscode-server/extensions/webhint.vscode-webhint-1.4.1/dist/bundle/server.js:13:6078)
    at async /home/sarvaje/.vscode-server/extensions/webhint.vscode-webhint-1.4.1/dist/bundle/server.js:1:80385
(node:1577) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:1577) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Maybe we should have a minimum version of webhint defined and tell the user if they not match the condition.

@sarvaje sarvaje added the type:bug label Nov 22, 2019
sarvaje added a commit to sarvaje/hint that referenced this issue Nov 22, 2019
@sarvaje sarvaje closed this in 24f54fd Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.