Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript-config/target error in VS code, but no browserslist. #3388

Closed
goldingdamien opened this issue Nov 23, 2019 · 4 comments · Fixed by #3415
Closed

typescript-config/target error in VS code, but no browserslist. #3388

goldingdamien opened this issue Nov 23, 2019 · 4 comments · Fixed by #3415
Assignees
Labels

Comments

@goldingdamien
Copy link

@goldingdamien goldingdamien commented Nov 23, 2019

I am getting "typescript-config/target" error from webhint via VScode extension.
According to the docs, this is checked via looking at browserslist configuration:
https://webhint.io/docs/user-guide/hints/hint-typescript-config/target/
I can't see any browserslist config in my project(Can only browserslist as a dependency in the yarn.lock file.).
What could be causing this issue?

Based on your browser configuration your "compilerOptions.target" should be "ES5". Current one is "ESNext"
(typescript-config/target)webhint

Environment

  • __hint version: 1.4.1
  • __Node.js version: 12.1.0
  • __npm version: 6.4.1
@molant

This comment has been minimized.

Copy link
Member

@molant molant commented Nov 23, 2019

@goldingdamien

This comment has been minimized.

Copy link
Author

@goldingdamien goldingdamien commented Nov 23, 2019

It's a nuxt project using Typescript. It includes Babel.
I thought because there is nothing specifying the environment that this hint would be ignored.
If there is a reason why the current functionality is preferred, please could you consider adding some additional documentation.

Regards.

@molant

This comment has been minimized.

Copy link
Member

@molant molant commented Nov 23, 2019

@molant

This comment has been minimized.

Copy link
Member

@molant molant commented Dec 4, 2019

@goldingdamien there's a PR to improve this (#3415). If everything goes well a new version will be released tomorrow.

@molant molant closed this in #3415 Dec 4, 2019
molant added a commit that referenced this issue Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.