New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish rules as standalone npm packages #748

Closed
alrra opened this Issue Jan 9, 2018 · 7 comments

Comments

Projects
None yet
2 participants
@alrra
Contributor

alrra commented Jan 9, 2018

  • Refactor code to make this possible.
  • Publish rules as standalone npm packages.
  • Update infrastructure and release script.
  • Update the wizard logic that displays the rules that can be installed. I'm thinking about doing an npm search and all rules that are under @sonarwhal should be in there
  • Delete the logic for core/no-core rules
  • Update the skeleton of the rules to include nyc

@alrra alrra self-assigned this Jan 9, 2018

@molant

This comment has been minimized.

Show comment
Hide comment
@molant

molant Jan 9, 2018

Member

For context, some of the reasons why we want to do this:

  • shorter and more reliable builds
  • update rules without having to update sonarwhal
  • be prepared to install rules on demand on first run
Member

molant commented Jan 9, 2018

For context, some of the reasons why we want to do this:

  • shorter and more reliable builds
  • update rules without having to update sonarwhal
  • be prepared to install rules on demand on first run
@molant

This comment has been minimized.

Show comment
Hide comment
@molant

molant Jan 16, 2018

Member

Some other things that we need to do in here:

  • Update the wizard logic that displays the rules that can be installed. I'm thinking about doing an npm search and all rules that are under @sonarwhal should be in there
  • Delete the logic for core/no-core rules
  • Update the skeleton of the rules to include nyc
Member

molant commented Jan 16, 2018

Some other things that we need to do in here:

  • Update the wizard logic that displays the rules that can be installed. I'm thinking about doing an npm search and all rules that are under @sonarwhal should be in there
  • Delete the logic for core/no-core rules
  • Update the skeleton of the rules to include nyc

@molant molant referenced this issue Jan 30, 2018

Closed

New: Ability to search npm packages #785

2 of 4 tasks complete

@poshaughnessy poshaughnessy referenced this issue Jan 30, 2018

Closed

Docs: Reorganize contributor guide #784

5 of 6 tasks complete
@alrra

This comment has been minimized.

Show comment
Hide comment
@alrra

alrra Feb 8, 2018

Contributor

Note: We are working on this in the fix-748 branch.

Contributor

alrra commented Feb 8, 2018

Note: We are working on this in the fix-748 branch.

@molant

This comment has been minimized.

Show comment
Hide comment
@molant

molant Feb 8, 2018

Member

Making a list to know what rules are passing or not with the current project. The ones that aren't checked and don't have a comment I haven't tested them yet.

  • amp-validator: has an issue installing on windows in the post-install script
  • apple-touch-icons
  • axe
  • content-type
  • disown-opener
  • highest-available-document-mode
  • html-checker: 2 failing tests with chrome concurrency issue solved adding the delay in chrome-launcher
  • http-cache
  • http-compression: 63 skipped tests (chrome is ignored)
  • image-optimization-cloudinary: 6 skipped tests (guess chrome is ignored)
  • manifest-app-name
  • manifest-exists
  • manifest-file-extension
  • manifest-is-valid
  • meta-charset-utf-8
  • meta-viewport
  • no-disallowed-headers
  • no-friendly-error-pages
  • no-html-only-headers
  • no-http-redirects
  • no-protocol-relative-urls
  • no-vulnerable-javascript-libraries
  • ssllabs: errors with ECONNRESET in 5 rules with chrome concurrency issue solved adding the delay in chrome-launcher
  • strict-transport-security: 10 errors in different connectors. Message Error with getting preload eligibility for https://localhost/. it's pretty common
  • validate-set-cookie-header: 28 skipped
  • x-content-type-options
Member

molant commented Feb 8, 2018

Making a list to know what rules are passing or not with the current project. The ones that aren't checked and don't have a comment I haven't tested them yet.

  • amp-validator: has an issue installing on windows in the post-install script
  • apple-touch-icons
  • axe
  • content-type
  • disown-opener
  • highest-available-document-mode
  • html-checker: 2 failing tests with chrome concurrency issue solved adding the delay in chrome-launcher
  • http-cache
  • http-compression: 63 skipped tests (chrome is ignored)
  • image-optimization-cloudinary: 6 skipped tests (guess chrome is ignored)
  • manifest-app-name
  • manifest-exists
  • manifest-file-extension
  • manifest-is-valid
  • meta-charset-utf-8
  • meta-viewport
  • no-disallowed-headers
  • no-friendly-error-pages
  • no-html-only-headers
  • no-http-redirects
  • no-protocol-relative-urls
  • no-vulnerable-javascript-libraries
  • ssllabs: errors with ECONNRESET in 5 rules with chrome concurrency issue solved adding the delay in chrome-launcher
  • strict-transport-security: 10 errors in different connectors. Message Error with getting preload eligibility for https://localhost/. it's pretty common
  • validate-set-cookie-header: 28 skipped
  • x-content-type-options
@molant

This comment has been minimized.

Show comment
Hide comment
@molant

molant Feb 8, 2018

Member

Forgot to mention the results above are with my current work. I had to fix something on jsdom when accessing the attributes so you might not get the same until my work is merged.

Member

molant commented Feb 8, 2018

Forgot to mention the results above are with my current work. I had to fix something on jsdom when accessing the attributes so you might not get the same until my work is merged.

@molant

This comment has been minimized.

Show comment
Hide comment
@molant

molant Feb 9, 2018

Member

All rules except the amp one are working now and pushed into the fix-748 branch.
There are some that need more test coverage like strict-transport-security. Will work on that next probably.

Member

molant commented Feb 9, 2018

All rules except the amp one are working now and pushed into the fix-748 branch.
There are some that need more test coverage like strict-transport-security. Will work on that next probably.

@alrra

This comment has been minimized.

Show comment
Hide comment
@alrra

alrra Feb 23, 2018

Contributor

This issue is kinda done, further improvements will be address separately.

Contributor

alrra commented Feb 23, 2018

This issue is kinda done, further improvements will be address separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment