New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Make `npm` package not include `npm-shrinkwrap.json` file #1294

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@alrra
Member

alrra commented Sep 6, 2018

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

Even though npm recommends:

The recommended use-case for npm-shrinkwrap.json is applications deployed through the publishing process on the registry: for example, daemons and command-line tools intended as global installs or devDependencies "

we found that this model did not work out for this project as:

... that would prevent end users from having control over transitive dependency updates. "

See also: https://docs.npmjs.com/files/shrinkwrap.json

@alrra alrra requested review from molant and sarvaje as code owners Sep 6, 2018

Fix: Make `npm` package not include `npm-shrinkwrap.json` file
Even though `npm` recommends:

 " The recommended use-case for `npm-shrinkwrap.json`
   is applications deployed through the publishing process
   on the registry: for example, daemons and **command-line
   tools** intended as global installs or devDependencies "

we found that this model did not work out for this project as:

  " ... that would prevent end users from having control over
    transitive dependency updates. "

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

See also: https://docs.npmjs.com/files/shrinkwrap.json

@alrra alrra force-pushed the npm-shrinkwrap.json branch from 1322b76 to 60981a1 Sep 6, 2018

@molant

molant approved these changes Sep 6, 2018

@alrra alrra closed this in 7cde2e1 Sep 6, 2018

@alrra alrra deleted the npm-shrinkwrap.json branch Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment