New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add new HTML formatter design #1326

Closed
wants to merge 11 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@sarvaje
Member

sarvaje commented Sep 19, 2018

Tasks left:

  • go to top button
  • info button

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

@sarvaje sarvaje requested review from alrra and molant as code owners Sep 19, 2018

@sarvaje sarvaje referenced this pull request Sep 19, 2018

Closed

Fix: Use the new html formatter #521

2 of 2 tasks complete

@sarvaje sarvaje force-pushed the sarvaje:formatter-html-new-design branch from b9b05b7 to 1ff2a54 Sep 19, 2018

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 60 72"><path fill="#acadda" d="M10.1 26.3L7 23.2c-3.7 4-5.8 9.2-6.1 14.6h4.3c.4-4.2 2.1-8.3 4.9-11.5zM23.2 20v-4.3c-5.4.2-10.6 2.4-14.6 6l3.1 3.1c3.1-2.9 7.2-4.6 11.5-4.8zm2.1 37.8v4.3c5.4-.2 10.6-2.4 14.6-6L36.8 53c-3.2 2.9-7.2 4.6-11.5 4.8zm-13.7-4.7l-3.1 3.1c4 3.7 9.2 5.8 14.6 6v-4.3c-4.2-.3-8.3-2-11.5-4.8zM5.3 40H1c.2 5.4 2.4 10.6 6 14.6l3.1-3.1C7.3 48.3 5.6 44.3 5.3 40zm37.9 0c-.2 4.3-1.9 8.3-4.8 11.5l3.1 3.1c3.7-4 5.8-9.2 6-14.6h-4.3z"/><path fill="#2d28a1" d="M29.5 29.4V9.8h-4.3v19.6h-2.6l4.7 8.2 4.7-8.2h-2.5zm29.1 5.7l-8.2-4.7V33H32.6v4.3h17.8v2.6l8.2-4.8z"/></svg>

This comment has been minimized.

@alrra

alrra Sep 20, 2018

Member
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 60 72"><path fill="#acadda" d="M10.1 26.3L7 23.2c-3.7 4-5.8 9.2-6.1 14.6h4.3c.4-4.2 2.1-8.3 4.9-11.5zM23.2 20v-4.3c-5.4.2-10.6 2.4-14.6 6l3.1 3.1A18 18 0 0 1 23.2 20zm2.1 37.8v4.3c5.4-.2 10.6-2.4 14.6-6L36.8 53a18.3 18.3 0 0 1-11.5 4.8zm-13.7-4.7l-3.1 3.1c4 3.7 9.2 5.8 14.6 6v-4.3c-4.2-.3-8.3-2-11.5-4.8zM5.3 40H1c.2 5.4 2.4 10.6 6 14.6l3.1-3.1A19.5 19.5 0 0 1 5.3 40zm37.9 0c-.2 4.3-1.9 8.3-4.8 11.5l3.1 3.1c3.7-4 5.8-9.2 6-14.6h-4.3z"/><path fill="#2d28a1" d="M29.5 29.4V9.8h-4.3v19.6h-2.6l4.7 8.2 4.7-8.2h-2.5zm29.1 5.7l-8.2-4.7V33H32.6v4.3h17.8v2.6l8.2-4.8z"/></svg>
@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" width="12" height="11"><path fill="#FFF" fill-rule="evenodd" d="M8.25 3c-.238 0-.461.001-.668.003a7.015 7.015 0 0 0-.606.032c-.198.02-.396.054-.595.103-.199.049-.41.12-.633.214a4.452 4.452 0 0 0-1.726 1.286 4.653 4.653 0 0 0-.58.908 4.372 4.372 0 0 0-.348 1.028 7.808 7.808 0 0 1 2.103-.99A8 8 0 0 1 7.5 5.25h.75v1.189l2.314-2.314L8.25 1.811V3zM7.5 6c-.5 0-.989.05-1.468.149-.478.1-.94.247-1.386.44A7.47 7.47 0 0 0 2.25 8.25V7.5a5.207 5.207 0 0 1 .718-2.651 5.25 5.25 0 0 1 1.881-1.881A5.207 5.207 0 0 1 7.5 2.25V0l4.125 4.125L7.5 8.25V6zm.75 3L9 8.25v2.25H0V3h.75v6.75h7.5V9z"/></svg>

This comment has been minimized.

@alrra

alrra Sep 20, 2018

Member
<svg xmlns="http://www.w3.org/2000/svg" width="12" height="12"><path fill="#fff" fill-rule="evenodd" d="M8.25 3h-.67a7.01 7.01 0 0 0-.6.04 4.28 4.28 0 0 0-1.23.31 4.45 4.45 0 0 0-1.73 1.29 4.65 4.65 0 0 0-.58.9 4.37 4.37 0 0 0-.35 1.03 7.8 7.8 0 0 1 2.1-.99 8 8 0 0 1 2.31-.33h.75v1.19l2.31-2.32-2.31-2.3V3zM7.5 6a7.23 7.23 0 0 0-2.85.59 7.47 7.47 0 0 0-2.4 1.66V7.5a5.2 5.2 0 0 1 .72-2.65 5.25 5.25 0 0 1 1.88-1.88 5.2 5.2 0 0 1 2.65-.72V0l4.13 4.13L7.5 8.25V6zm.75 3L9 8.25v2.25H0V3h.75v6.75h7.5V9z"/></svg>
@@ -0,0 +1,3 @@
<?xml version="1.0"?>
<!--Icons from directory ""-->
<svg xmlns="http://www.w3.org/2000/svg" width="22" height="44" viewBox="0 0 22 44"><svg width="22" height="22" id="close" y="0"><path d="M11 0c6.075 0 11 4.925 11 11s-4.925 11-11 11S0 17.075 0 11 4.925 0 11 0zm0 1c5.523 0 10 4.477 10 10s-4.477 10-10 10S1 16.523 1 11 5.477 1 11 1zm5.5 10.5h-11v-1h11v1z" fill="#4046DD" fill-rule="evenodd"/></svg><svg width="22" height="22" id="open" y="22"><path d="M11 0c6.075 0 11 4.925 11 11s-4.925 11-11 11S0 17.075 0 11 4.925 0 11 0zm0 1c5.523 0 10 4.477 10 10s-4.477 10-10 10S1 16.523 1 11 5.477 1 11 1zm5.5 10.5h-5v5h-1v-5h-5v-1h5v-5h1v5h5v1z" fill="#4046DD" fill-rule="evenodd"/></svg></svg>

This comment has been minimized.

@alrra

alrra Sep 20, 2018

Member
<svg xmlns="http://www.w3.org/2000/svg" width="22" height="44"><svg width="22" height="22"><path fill="#4046dd" fill-rule="evenodd" d="M11 0a11 11 0 1 1 0 22 11 11 0 0 1 0-22zm0 1a10 10 0 1 1 0 20 10 10 0 0 1 0-20zm5.5 10.5h-11v-1h11v1z"/></svg><svg width="22" height="22" y="22"><path fill="#4046dd" fill-rule="evenodd" d="M11 0a11 11 0 1 1 0 22 11 11 0 0 1 0-22zm0 1a10 10 0 1 1 0 20 10 10 0 0 1 0-20zm5.5 10.5h-5v5h-1v-5h-5v-1h5v-5h1v5h5v1z"/></svg></svg>
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 47 72"><path fill="#acadda" d="M32.8 59.3h-19C6.2 59.3 0 53.1 0 45.5v-19c0-7.6 6.2-13.8 13.8-13.8h19c7.6 0 13.8 6.2 13.8 13.8v19c0 7.6-6.1 13.8-13.8 13.8zM13.8 17c-5.2 0-9.5 4.3-9.5 9.5v19c0 5.2 4.3 9.5 9.5 9.5h19c5.2 0 9.5-4.3 9.5-9.5v-19c0-5.2-4.3-9.5-9.5-9.5h-19z"/><path fill="#2d28a1" d="M16.7 33.4c.5.4.7 1 .6 1.7 0 .7-.2 1.3-.7 1.8-.5.4-1.2.7-1.9.6h-1.1v1.8h-1.7v-6.4h2.8c.7-.1 1.4.1 2 .5zm-1.2 2.4c.2-.2.3-.5.3-.7 0-.3-.1-.5-.3-.7-.2-.2-.5-.3-.8-.2h-1.1v2h1.1c.3-.1.5-.2.8-.4zm12.4-3l-2.2 6.4H24l-1.2-4.4-1.2 4.4h-1.7l-2.2-6.4h1.8l1.3 4.7 1.3-4.7h1.6l1.3 4.7 1.2-4.7h1.7zm4.6 5.3h-2.8l-.5 1.1h-1.7l2.8-6.4H32l2.7 6.4h-1.8l-.4-1.1zm-.5-1.3l-.9-2.3-.9 2.3H32z"/></svg>

This comment has been minimized.

@alrra

alrra Sep 20, 2018

Member
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 47 72"><path fill="#acadda" d="M32.8 59.3h-19C6.2 59.3 0 53.1 0 45.5v-19c0-7.6 6.2-13.8 13.8-13.8h19c7.6 0 13.8 6.2 13.8 13.8v19c0 7.6-6.1 13.8-13.8 13.8zM13.8 17a9.6 9.6 0 0 0-9.5 9.5v19c0 5.2 4.3 9.5 9.5 9.5h19c5.2 0 9.5-4.3 9.5-9.5v-19c0-5.2-4.3-9.5-9.5-9.5h-19z"/><path fill="#2d28a1" d="M16.7 33.4c.5.4.7 1 .6 1.7 0 .7-.2 1.3-.7 1.8-.5.4-1.2.7-1.9.6h-1.1v1.8h-1.7v-6.4h2.8c.7-.1 1.4.1 2 .5zm-1.2 2.4c.2-.2.3-.5.3-.7a1 1 0 0 0-.3-.7.8.8 0 0 0-.8-.2h-1.1v2h1.1l.8-.4zm12.4-3l-2.2 6.4H24l-1.2-4.4-1.2 4.4h-1.7l-2.2-6.4h1.8l1.3 4.7 1.3-4.7h1.6l1.3 4.7 1.2-4.7h1.7zm4.6 5.3h-2.8l-.5 1.1h-1.7l2.8-6.4H32l2.7 6.4h-1.8l-.4-1.1zm-.5-1.3l-.9-2.3-.9 2.3H32z"/></svg>
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 45 72"><style>.e{fill:#acadda}.s{fill:#2d28a1}</style><path d="M31.8 21.3V10.6c0-1.2-1-2.2-2.2-2.1H14.8c-1.2 0-2.2 1-2.2 2.2v10.6C1.6 26.5-3.1 39.8 2.2 50.9s18.5 15.8 29.6 10.5 15.8-18.5 10.5-29.6c-2.2-4.6-5.9-8.3-10.5-10.5zM17 12.8h10.5v6.9c-3.4-.8-7-.8-10.5 0v-6.9zm5.2 46.4c-9.9 0-17.9-8-17.9-17.9s8-17.9 17.9-17.9c9.9 0 17.9 8 17.9 17.9 0 9.9-8 17.9-17.9 17.9z" class="e"/><path d="M19.8 41.9h4.8v7.2c0 1.3-1.1 2.4-2.4 2.4s-2.4-1.1-2.4-2.4v-7.2z" class="s"/><circle cx="22.2" cy="38.7" r="4.7" class="s"/></svg>

This comment has been minimized.

@alrra

alrra Sep 20, 2018

Member
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 45 72"><style>.s{fill:#2d28a1}</style><path fill="#acadda" d="M31.8 21.3V10.6c0-1.2-1-2.2-2.2-2.1H14.8c-1.2 0-2.2 1-2.2 2.2v10.6C1.6 26.5-3.1 39.8 2.2 50.9s18.5 15.8 29.6 10.5 15.8-18.5 10.5-29.6a22.3 22.3 0 0 0-10.5-10.5zM17 12.8h10.5v6.9c-3.4-.8-7-.8-10.5 0v-6.9zm5.2 46.4c-9.9 0-17.9-8-17.9-17.9s8-17.9 17.9-17.9c9.9 0 17.9 8 17.9 17.9 0 9.9-8 17.9-17.9 17.9z"/><path d="M19.8 41.9h4.8v7.2c0 1.3-1.1 2.4-2.4 2.4s-2.4-1.1-2.4-2.4v-7.2z" class="s"/><circle cx="22.2" cy="38.7" r="4.7" class="s"/></svg>
@@ -0,0 +1,656 @@
<!DOCTYPE html>

This comment has been minimized.

@alrra

alrra Sep 20, 2018

Member

<!doctype html>

This comment has been minimized.

@sarvaje

sarvaje Sep 20, 2018

Member

Don't worry about this file, I forgot to remove it.

<head>
<meta charset="utf-8">
<title>Page Title</title>
<meta name="viewport" content="width=device-width, initial-scale=1">

This comment has been minimized.

@alrra

alrra Sep 20, 2018

Member

Drop initial-scale=1

<title>Page Title</title>
<meta name="viewport" content="width=device-width, initial-scale=1">

This comment has been minimized.

@alrra

alrra Sep 20, 2018

Member

Remove extra empty lines here, and everywhere else.

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 50 72"><style>.a{fill:#2d28a1}.b{fill:#817ec7}.c{fill:#5753b4}.d{fill:#0b0687}.e{fill:#acadda}.f{fill:none;stroke:#4046dD;stroke-width:4;stroke-linecap:round;stroke-linejoin:round}</style><path d="M38.4 33.6c-3.5-2.9-7.8-4.6-12.3-4.9v7.8c2.4.2 4.8 1.1 6.7 2.7l5.6-5.6z" class="a"/><path d="M10 35.1c-3.3 3.4-5.3 7.8-5.7 12.5h8.3c.3-2.5 1.3-5 3-6.9L10 35.1z" class="b"/><path d="M23.9 28.7c-4.5.2-8.8 1.9-12.3 4.9l5.6 5.6c1.9-1.5 4.2-2.5 6.7-2.7v-7.8z" class="c"/><path d="M40 35.1l-5.6 5.6c1.7 1.9 2.7 4.3 3 6.9h8.3c-.5-4.7-2.5-9.1-5.7-12.5z" class="d"/><path d="M7 32C2.9 36.2.4 41.7 0 47.6h4.3c.4-4.7 2.4-9.1 5.7-12.5L7 32zm16.9-7.6c-5.7.2-11.1 2.4-15.4 6.1l3.1 3.1c3.5-2.9 7.8-4.6 12.3-4.9v-4.3zm17.5 6.1c-4.3-3.7-9.7-5.9-15.3-6.1v4.3c4.5.2 8.8 1.9 12.3 4.9l3-3.1zM50 47.6c-.4-5.9-2.9-11.4-7-15.6l-3 3c3.3 3.4 5.3 7.8 5.7 12.5l4.3.1z" class="e"/><path d="M39.7 42.3l-14.2 4.8" class="f"/></svg>

This comment has been minimized.

@alrra

alrra Sep 20, 2018

Member
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 50 72"><path fill="#2d28a1" d="M38.4 33.6a21.5 21.5 0 0 0-12.3-4.9v7.8a12 12 0 0 1 6.7 2.7l5.6-5.6z"/><path fill="#817ec7" d="M10 35.1a20.4 20.4 0 0 0-5.7 12.5h8.3c.3-2.5 1.3-5 3-6.9L10 35.1z"/><path fill="#5753b4" d="M23.9 28.7c-4.5.2-8.8 1.9-12.3 4.9l5.6 5.6c1.9-1.5 4.2-2.5 6.7-2.7v-7.8z"/><path fill="#0b0687" d="M40 35.1l-5.6 5.6c1.7 1.9 2.7 4.3 3 6.9h8.3c-.5-4.7-2.5-9.1-5.7-12.5z"/><path fill="#acadda" d="M7 32a24.7 24.7 0 0 0-7 15.6h4.3c.4-4.7 2.4-9.1 5.7-12.5L7 32zm16.9-7.6a25 25 0 0 0-15.4 6.1l3.1 3.1c3.5-2.9 7.8-4.6 12.3-4.9v-4.3zm17.5 6.1a25 25 0 0 0-15.3-6.1v4.3c4.5.2 8.8 1.9 12.3 4.9l3-3.1zM50 47.6A24.7 24.7 0 0 0 43 32l-3 3c3.3 3.4 5.3 7.8 5.7 12.5l4.3.1z"/><path fill="none" stroke="#4046dd" stroke-linecap="round" stroke-linejoin="round" stroke-width="4" d="M39.7 42.3l-14.2 4.8"/></svg>
<a href="https://github.com/dequelabs/axe-core">
<img src="images/scan/axe.png" alt="aXe" class="axe-logo" />

This comment has been minimized.

@alrra

alrra Sep 20, 2018

Member

Remove trailing / here and everywhere else.

@@ -0,0 +1,82 @@
/* global setImmediate */
/* eslint-disable no-var,prefer-arrow-callback,prefer-template */
(function () {

This comment has been minimized.

@molant

molant Sep 20, 2018

Member

I think we should rename this file and some of its methods from accordion to details

@@ -0,0 +1,82 @@
/* global setImmediate */

This comment has been minimized.

@molant

molant Sep 20, 2018

Member

setImmediate is not used here

@@ -0,0 +1,11 @@
/* eslint-disable no-var */
(function () {

This comment has been minimized.

@molant

molant Sep 20, 2018

Member

We can probably drop this polyfill and have a setTimeout(func,0) where needed.

Show resolved Hide resolved packages/formatter-html/src/assets/js/scan/scanner-common.js
Show resolved Hide resolved packages/formatter-html/src/assets/styles/fonts.css
@@ -189,6 +193,10 @@ export default class AnalysisResult {
return time;
}
private parseTimeStamp(timeStamp: number): string {
return moment(timeStamp).format('YYYY-MM-DD H:mm');

This comment has been minimized.

@molant

molant Sep 20, 2018

Member

We can probably get away without moment for this (it's pretty big). Also maybe this should be done in the client side to take into account the local time zone?

This comment has been minimized.

@molant

molant Sep 28, 2018

Member

Because this is done in the server side, maybe we should change the format to include the timezone? Does the timestamp use GMT? Something like 2018-09-27 15:12 (GMT+0) or something like that. Or maybe it's a bit overkill? It worries me that in the website the value we are going to show might be off for the user.

@@ -0,0 +1 @@
<img src="/images/scan/results-passed-icon.svg" />

This comment has been minimized.

@molant

molant Sep 20, 2018

Member

There's a missing alt here.

<p class="rule-tile__category"><%= category.name.toUpperCase() %></p>
<div class="rule-tile__results">
<div class="rule-tile__result-wrapper">
<p class="rule-tile__sub-category">HINTS</p>

This comment has been minimized.

@molant

molant Sep 20, 2018

Member

What do you think of using CSS for the casing? We might want to try with other formats and will probably be easier to change or A/B test globally.

This comment has been minimized.

@sarvaje

sarvaje Sep 20, 2018

Member

This not a problem, we still can change the case via CSS.

<div class="rule-content">
<div class="rule-doc-buttons">
<a class="rule-doc-button" rel="noopener noreferrer" target="_blank" href="https://webhint.io/docs/user-guide/hints/hint-<%= hint.name %>/#why-is-this-important"
title="Why is this important for <%= hint.name %> rule">

This comment has been minimized.

@molant

molant Sep 20, 2018

Member

We no longer call them rule but hint. This applies to other places where the user can read.
Also the title reads a bit weird. E.g.:

Why is this important for Require resources to be served compressed hint/rule

Maybe surround the name in "? Or <%= hint.name %> - Why is this important ?

Show resolved Hide resolved packages/formatter-html/src/views/partials/scan-result-item.ejs
@ststimac

This comment has been minimized.

Member

ststimac commented Sep 20, 2018

@sarvaje let me know when you get the info button implemented (that's the little "i" right?) Just created this component in totally accessible way in a workshop via click. If we have people hover over the information icon then it won't be accessible.

@sarvaje

This comment has been minimized.

Member

sarvaje commented Sep 20, 2018

that's the little "i" right?

Yes.

@ststimac can you give me more information about that? So I can implement it accessible directly :)

@alrra alrra changed the title from Fix: New html formatter design to Fix: Add New HTML formatter design Sep 20, 2018

@alrra alrra changed the title from Fix: Add New HTML formatter design to Fix: Add new HTML formatter design Sep 20, 2018

@@ -0,0 +1 @@
<img src="/images/scan/results-passed-icon.svg" alt="Passed" />

This comment has been minimized.

@alrra

alrra Sep 20, 2018

Member

Remove trailing /.

<div class="scan-overview--permalink">
<p class="scan-overview__subheader scan-overview__body__permalink">Your scan result link:
<button class="permalink-copy">
<span class="permalink-content"><%= result.permalink %></span> <img src="/images/scan/permalink-icon.svg" />

This comment has been minimized.

@alrra

alrra Sep 20, 2018

Member

Remove trailing /.

<% } %>
</div>
<a href="<%= hint.thirdPartyInfo.link %>">
<img src="<%= hint.thirdPartyInfo.logo.url %>" alt="<%= hint.thirdPartyInfo.logo.alt %>" class="<%= hint.thirdPartyInfo.logo.name %>-logo" />

This comment has been minimized.

@alrra

alrra Sep 20, 2018

Member

Remove trailing /.

@molant

This comment has been minimized.

Member

molant commented Sep 24, 2018

A few pending and comments:

  • Update the image of the formatter in the docs
  • Mention (in the docs?) that links to the documentation of custom rules will not work (and maybe open an issue?)
  • We should only print the aXe logo once instead of each rule. I think this applies also to snyk and others if they can output multiple errors.

Also in IE11 it renders fine. No sticky headers but I think that's fine 😊

@alrra alrra force-pushed the webhintio:master branch 2 times, most recently from e1993b0 to 6c3bfae Sep 25, 2018

@sarvaje

This comment has been minimized.

Member

sarvaje commented Sep 28, 2018

@ststimac can you share with me some example about the info button? thanks!

@sarvaje sarvaje force-pushed the sarvaje:formatter-html-new-design branch from 46313c2 to 8d1208d Sep 28, 2018

var menu = parent.querySelector('.rule-categories');
if (menu.classList.contains('open')) {
showMenuElement.textContent = 'SHOW CATEGORIES';

This comment has been minimized.

@molant

molant Sep 28, 2018

Member

I think we were controlling the casing via CSS, right? If so can you make it lower case here and everywhere else?

This comment has been minimized.

@sarvaje

sarvaje Sep 28, 2018

Member

The text is wrong, we talk about say jump to category and no, we weren't controlling the casting in that element. I'm fixing it.

var permalinkImageElement = parentElement.querySelector('img');
if (!window.ejsPartials) {
permalinkImageElement.src = '/images/scan/results-passed-icon.svg';

This comment has been minimized.

@molant

molant Sep 28, 2018

Member

This url gets updated during the optimization process, right?

This comment has been minimized.

@sarvaje

sarvaje Sep 28, 2018

Member

TBH, I don't remember in which cases we run this if, but in production we should run the else of this if.

public errors: number;
/** Number of suggestions. */
public hintsCount: number;
/** Scan time */

This comment has been minimized.

@molant

molant Sep 28, 2018

Member

Missing final .

@@ -62,6 +62,9 @@ The officially supported `formatter`s that can be installed via `npm` are:
![Example out for the HTML result of the html formatter](images/html-output.png)
Note: If you are runing customs hints and the buttons `Why is this important`

This comment has been minimized.

@molant

molant Sep 28, 2018

Member

If you are running custom hints and the buttons...

</div>
<% } else { %>
<div class="scan-overview--time-stamp">
<p class="scan-overview__subheader">time stamp: <span class="overview--time-stamp__time-stamp"><%= result.timeStamp %></span></p>

This comment has been minimized.

@molant

molant Sep 28, 2018

Member

We are using the date here in stead of the timestamp. Maybe it should be just Date: or something like that?

This comment has been minimized.

@sarvaje

sarvaje Sep 28, 2018

Member

sounds good

sarvaje added some commits Sep 28, 2018

@ststimac

This comment has been minimized.

Member

ststimac commented Oct 1, 2018

@sarvaje I've sent you an email with an example.

@alrra alrra closed this in aa52c56 Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment