New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update `jsdom` to `v12.1.0` #1357

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@molant
Member

molant commented Oct 1, 2018

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

  • Update to latest jsdom version.
  • Remove @types/jsdom to avoid TypeScript problems.
  • Enable includeNodeLocations to jsdom.
  • Add polyfills to increase compatibility.

Fix #163
Fix #1289
Fix #1223

This is #1274 with the commits squashed and rebased

@molant molant requested review from alrra and sarvaje as code owners Oct 1, 2018

@alrra alrra referenced this pull request Oct 1, 2018

Closed

Update to jsdom v12 #1274

3 of 4 tasks complete

@molant molant force-pushed the molant:jsdom-update-v12 branch 4 times, most recently from c70671d to 86bb59e Oct 1, 2018

@molant

This comment has been minimized.

Member

molant commented Oct 1, 2018

@antross I'm having issues with types, jsdom and strict. Some help here on what would be the best approach?

@molant molant force-pushed the molant:jsdom-update-v12 branch from 86bb59e to bd6f502 Oct 2, 2018

@antross antross force-pushed the molant:jsdom-update-v12 branch from bd6f502 to cc89315 Oct 2, 2018

Fix: Update `jsdom` to `v12.1.0`
* Update to latest `jsdom` version.
* Enable `includeNodeLocations` to jsdom.
* Improve `@types/jsdom` with ResourceLoader.
* Add polyfills to increase compatibility.

- - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix #163
Fix #1289
Fix #1223

@molant molant force-pushed the molant:jsdom-update-v12 branch from cc89315 to 8c5ee7a Oct 2, 2018

@molant

This comment has been minimized.

Member

molant commented Oct 2, 2018

It looks like Travis is passing. Thanks a lot @antross !

@alrra alrra closed this in f825d20 Oct 3, 2018

@molant molant deleted the molant:jsdom-update-v12 branch Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment