New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Deprecate unused `Configuration` methods #1610

Merged
merged 1 commit into from Jan 9, 2019

Conversation

Projects
None yet
4 participants
@antross
Copy link
Member

antross commented Jan 7, 2019

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

Both fromFilePath and loadBrowsersList are no longer used by
the online scanner, CLI, or extensions. Deprecating prior to removal
since these APIs are public.

@antross antross requested review from alrra , molant and sarvaje as code owners Jan 7, 2019

Show resolved Hide resolved packages/hint/src/lib/config.ts Outdated
@molant

This comment was marked as resolved.

Copy link
Member

molant commented Jan 8, 2019

@antross antross force-pushed the antross:deprecate-configuration-apis branch from 67ad374 to 4eaf9f9 Jan 8, 2019

@antross antross added this to the 1901-1 milestone Jan 8, 2019

@antross antross self-assigned this Jan 8, 2019

@sarvaje

sarvaje approved these changes Jan 8, 2019

@alrra

alrra approved these changes Jan 8, 2019

@molant
Copy link
Member

molant left a comment

Can I haz tests? logging.ts is one of the few where we have 100% coverage at the moment 😁

@antross

This comment has been minimized.

Copy link
Member

antross commented Jan 9, 2019

If I have to. ;) I’m busy at the moment, but will update the PR tomorrow.

Chore: Deprecate unused `Configuration` methods
Both `fromFilePath` and `loadBrowsersList` are no longer used by
the online scanner, CLI, or extensions. Deprecating prior to removal
since these APIs are public.

@antross antross force-pushed the antross:deprecate-configuration-apis branch from 4eaf9f9 to b3c09d1 Jan 9, 2019

@antross

This comment has been minimized.

Copy link
Member

antross commented Jan 9, 2019

@molant logger.warn - now with tests! 😁

@molant

molant approved these changes Jan 9, 2019

@molant molant merged commit 4516544 into webhintio:master Jan 9, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
licence/cla Contributor License Agreement is signed.
Details

@antross antross deleted the antross:deprecate-configuration-apis branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment